From mboxrd@z Thu Jan 1 00:00:00 1970 From: "K. Schnass" Subject: Re: [PATCH 069/165] drm/radeon/kms: add common dpm infrastructure Date: Thu, 27 Jun 2013 15:52:19 +0200 Message-ID: <1507233.jAAOKXZF3Q@my-little-devil> References: <1372253045-17042-70-git-send-email-alexdeucher@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail2.student.tuwien.ac.at (mail2.student.tuwien.ac.at [193.170.74.22]) by gabe.freedesktop.org (Postfix) with ESMTP id 959D6E5CD4 for ; Thu, 27 Jun 2013 07:03:42 -0700 (PDT) Received: from my-little-devil.localnet (91-119-80-117.dynamic.xdsl-line.inode.at [91.119.80.117]) (authenticated bits=0) by mail2.student.tuwien.ac.at (8.13.8/8.13.8) with ESMTP id r5RDrjcD009260 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 27 Jun 2013 15:53:45 +0200 In-Reply-To: <1372253045-17042-70-git-send-email-alexdeucher@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Thanks for the work the whole thing seems to work fine on my RV770, although I cannot really say if does anything as I found no way to query the current clk or voltage?! There is one little gripe though, the rest of the code uses DRM_INFO() for printing whereas this series uses plain printk() resulting in some weird looking dmesg output: Jun 27 14:41:54 my-little-devil kernel: [drm] VGA-1 Jun 27 14:41:54 my-little-devil kernel: [drm] DDC: 0x7e60 0x7e60 0x7e64 0x7e64 0x7e68 0x7e68 0x7e6c 0x7e6c Jun 27 14:41:54 my-little-devil kernel: [drm] Encoders: Jun 27 14:41:54 my-little-devil kernel: [drm] CRT2: INTERNAL_KLDSCP_DAC2 Jun 27 14:41:54 my-little-devil kernel: [drm] Internal thermal controller with fan control Jun 27 14:41:54 my-little-devil kernel: == power state 0 == Jun 27 14:41:54 my-little-devil kernel: ui class: none Jun 27 14:41:54 my-little-devil kernel: internal class: boot Jun 27 14:41:54 my-little-devil kernel: caps: video Jun 27 14:41:54 my-little-devil kernel: uvd vclk: 0 dclk: 0 Jun 27 14:41:54 my-little-devil kernel: power level 0 sclk: 62500 mclk: 99300 vddc: 1123 Jun 27 14:41:54 my-little-devil kernel: power level 1 sclk: 62500 mclk: 99300 vddc: 1123 Jun 27 14:41:54 my-little-devil kernel: power level 2 sclk: 62500 mclk: 99300 vddc: 1123 best regards K. Schnass