From: "Valluri, Amarnath" <amarnath.valluri@intel.com>
To: "Jeff.Glanz@dell.com" <Jeff.Glanz@dell.com>,
"yocto@yoctoproject.org" <yocto@yoctoproject.org>
Cc: "Michael.E.Brown@dell.com" <Michael.E.Brown@dell.com>
Subject: Re: Kernel driver installs broken in poky2.3
Date: Fri, 6 Oct 2017 08:12:12 +0000 [thread overview]
Message-ID: <1507277561.4061.7.camel@intel.com> (raw)
In-Reply-To: <96841aee253542c099d45ff7a5297981@ausx13mpc121.AMER.DELL.COM>
[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]
Hi Jeff,
Sorry to hear about the failure,
The change was part of adding merged /usr support for oecore. 'INSTALL_MOD_PATH' was using '/lib/modules/${KERNEL_VERSION}' as kernel modules path, where as in merged /usr environments it would be '/usr/lib/modules/${KERNEL_VERSION}'., And there is no way to fix this by using INSTALL_MOD_PATH, So I had to use MODLIB by replacing hardcoded '/lib' with appropriate bitbake variable .ie., ${nonarch_base_libdir}.
- Amarnath
On Thu, 2017-10-05 at 20:34 +0000, Jeff.Glanz@dell.com wrote:
Re: poky2.3 kernel driver install’s
Poky release, pyro (2.3), file: meta/classes/module.bbclass
This change, made in January 2017, is breaking do_install's for our kernel drivers, as INSTALL_MOD_PATH is not defined. Our Makefiles reference this variable.
What was the purpose of this particular change?
diff:
commit 0decf1cc1c35dd70f3b822e3b4291a810a319ba0
Author: Amarnath Valluri <amarnath.valluri@intel.com>
Date: Wed Jan 4 13:58:23 2017 +0200
kernel: use ${nonarch_base_libdir} for kernel modules installation.
Replace hardcoded '/lib' in kernel modules installation path with
${nonarch_base_libdir}, which is meant exactly for this.
(From OE-Core rev: 22f5ba7154fcbe826d0a3283740903312b2aab46)
Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
. . .
diff --git a/meta/classes/module.bbclass b/meta/classes/module.bbclass
index 99b7ebc..802476b 100644
--- a/meta/classes/module.bbclass
+++ b/meta/classes/module.bbclass
@@ -31,7 +31,7 @@ module_do_compile() {
module_do_install() {
unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
- oe_runmake DEPMOD=echo INSTALL_MOD_PATH="${D}" \
+ oe_runmake DEPMOD=echo MODLIB="${D}${nonarch_base_libdir}/modules/${KERNEL_VERSION}" \
Thanks!
Jeff Glanz
Senior Dev Prin Engineer, SCM & Release Engineering
Dell EMC | Server Solutions
Jeff.Glanz@dell.com<mailto:Jeff.Glanz@dell.com>
[-- Attachment #2: Type: text/html, Size: 10200 bytes --]
prev parent reply other threads:[~2017-10-06 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 20:34 Kernel driver installs broken in poky2.3 Jeff.Glanz
2017-10-06 8:12 ` Valluri, Amarnath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507277561.4061.7.camel@intel.com \
--to=amarnath.valluri@intel.com \
--cc=Jeff.Glanz@dell.com \
--cc=Michael.E.Brown@dell.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.