Kernel driver installs broken in poky2.3

Kernel driver installs broken in poky2.3

[Jeff.Glanz]

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]

Re: poky2.3 kernel driver install's



Poky release, pyro (2.3), file: meta/classes/module.bbclass

This change, made in January 2017, is breaking  do_install's for our kernel drivers, as INSTALL_MOD_PATH is not defined.  Our Makefiles reference this variable.

What was the purpose of this particular change?



diff:

commit 0decf1cc1c35dd70f3b822e3b4291a810a319ba0

Author: Amarnath Valluri <amarnath.valluri@intel.com>

Date:   Wed Jan 4 13:58:23 2017 +0200



    kernel: use ${nonarch_base_libdir} for kernel modules installation.



    Replace hardcoded '/lib' in kernel modules installation path with

    ${nonarch_base_libdir}, which is meant exactly for this.



    (From OE-Core rev: 22f5ba7154fcbe826d0a3283740903312b2aab46)



    Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com>

    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

. . .

diff --git a/meta/classes/module.bbclass b/meta/classes/module.bbclass

index 99b7ebc..802476b 100644

--- a/meta/classes/module.bbclass

+++ b/meta/classes/module.bbclass

@@ -31,7 +31,7 @@ module_do_compile() {



module_do_install() {

    unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS

-   oe_runmake DEPMOD=echo INSTALL_MOD_PATH="${D}" \

+ oe_runmake DEPMOD=echo MODLIB="${D}${nonarch_base_libdir}/modules/${KERNEL_VERSION}" \

Thanks!

Jeff Glanz
Senior Dev Prin Engineer, SCM & Release Engineering
Dell EMC | Server Solutions
Jeff.Glanz@dell.com<mailto:Jeff.Glanz@dell.com>


[-- Attachment #2: Type: text/html, Size: 9484 bytes --]

Re: Kernel driver installs broken in poky2.3

[Valluri, Amarnath]

[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]

Hi Jeff,

Sorry to hear about the failure,

The change was part of adding merged /usr support for oecore. 'INSTALL_MOD_PATH' was using '/lib/modules/${KERNEL_VERSION}' as kernel modules path, where as in merged /usr environments it would  be '/usr/lib/modules/${KERNEL_VERSION}'., And there is no way to fix this by using INSTALL_MOD_PATH, So I had to use MODLIB by replacing hardcoded '/lib' with appropriate bitbake variable .ie., ${nonarch_base_libdir}.


- Amarnath


On Thu, 2017-10-05 at 20:34 +0000, Jeff.Glanz@dell.com wrote:

Re: poky2.3 kernel driver install’s



Poky release, pyro (2.3), file: meta/classes/module.bbclass

This change, made in January 2017, is breaking  do_install's for our kernel drivers, as INSTALL_MOD_PATH is not defined.  Our Makefiles reference this variable.

What was the purpose of this particular change?



diff:

commit 0decf1cc1c35dd70f3b822e3b4291a810a319ba0

Author: Amarnath Valluri <amarnath.valluri@intel.com>

Date:   Wed Jan 4 13:58:23 2017 +0200



    kernel: use ${nonarch_base_libdir} for kernel modules installation.



    Replace hardcoded '/lib' in kernel modules installation path with

    ${nonarch_base_libdir}, which is meant exactly for this.



    (From OE-Core rev: 22f5ba7154fcbe826d0a3283740903312b2aab46)



    Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com>

    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

. . .

diff --git a/meta/classes/module.bbclass b/meta/classes/module.bbclass

index 99b7ebc..802476b 100644

--- a/meta/classes/module.bbclass

+++ b/meta/classes/module.bbclass

@@ -31,7 +31,7 @@ module_do_compile() {



module_do_install() {

    unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS

-   oe_runmake DEPMOD=echo INSTALL_MOD_PATH="${D}" \

+ oe_runmake DEPMOD=echo MODLIB="${D}${nonarch_base_libdir}/modules/${KERNEL_VERSION}" \

Thanks!

Jeff Glanz
Senior Dev Prin Engineer, SCM & Release Engineering
Dell EMC | Server Solutions
Jeff.Glanz@dell.com<mailto:Jeff.Glanz@dell.com>


[-- Attachment #2: Type: text/html, Size: 10200 bytes --]