From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753361AbdJFJc1 (ORCPT ); Fri, 6 Oct 2017 05:32:27 -0400 Received: from smtprelay0034.hostedemail.com ([216.40.44.34]:42592 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751827AbdJFJcZ (ORCPT ); Fri, 6 Oct 2017 05:32:25 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:69:355:379:541:599:800:960:973:988:989:1042:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2736:2828:2898:2911:3138:3139:3140:3141:3142:3353:3622:3865:3870:4321:4425:5007:7576:7903:7904:10004:10400:10848:11026:11232:11658:11914:12043:12114:12438:12555:12740:12760:12895:12986:13069:13255:13311:13357:13439:14181:14659:14721:14819:21080:21433:21451:21627:30054:30064:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: boat24_31fe705b7201e X-Filterd-Recvd-Size: 2713 Message-ID: <1507282342.4434.60.camel@perches.com> Subject: Re: [PATCH 3.18 14/35] pinctrl: mvebu: Use seq_puts() in mvebu_pinconf_group_dbg_show() From: Joe Perches To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Markus Elfring , Linus Walleij , Sasha Levin Date: Fri, 06 Oct 2017 02:32:22 -0700 In-Reply-To: <20171006092403.375551386@linuxfoundation.org> References: <20171006092402.810400570@linuxfoundation.org> <20171006092403.375551386@linuxfoundation.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-10-06 at 11:24 +0200, Greg Kroah-Hartman wrote: > 3.18-stable review patch. If anyone has any objections, please let me know. Same deal, trivial cpu savings only, no place in stable unless another patch depends on this one. > ------------------ > > From: Markus Elfring > > > [ Upstream commit 420dc61642920849d824a0de2aa853db59f5244f ] > > Strings which did not contain data format specifications should be put > into a sequence. Thus use the corresponding function "seq_puts". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > Signed-off-by: Linus Walleij > Signed-off-by: Sasha Levin > Signed-off-by: Greg Kroah-Hartman > --- > drivers/pinctrl/mvebu/pinctrl-mvebu.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > --- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c > +++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c > @@ -195,11 +195,12 @@ static void mvebu_pinconf_group_dbg_show > seq_printf(s, "o"); > seq_printf(s, ")"); > } > - } else > - seq_printf(s, "current: UNKNOWN"); > + } else { > + seq_puts(s, "current: UNKNOWN"); > + } > > if (grp->num_settings > 1) { > - seq_printf(s, ", available = ["); > + seq_puts(s, ", available = ["); > for (n = 0; n < grp->num_settings; n++) { > if (curr == &grp->settings[n]) > continue; > @@ -222,7 +223,7 @@ static void mvebu_pinconf_group_dbg_show > seq_printf(s, ")"); > } > } > - seq_printf(s, " ]"); > + seq_puts(s, " ]"); > } > return; > } > >