Re: [PATCH 1/2] drm/i915: avoid unnecessary call to intel_hpd_pin_to_port

[Paulo Zanoni <paulo.r.zanoni@intel.com>]

Em Qui, 2017-10-05 às 14:49 -0700, Rodrigo Vivi escreveu:
> On Thu, Oct 05, 2017 at 09:38:41PM +0000, Paulo Zanoni wrote:
> > Don't call it when we can do like the other functions and just look
> > at
> > port->port. Also rename the intel_digital_port variable to make it
> > look like the other functions.
> 
> what other functions?

All the _digital_port_connected() functions from intel_dp.c.

> 
> Most of our functions use intel_dig_port. Also dport and less used is
> port.
> 
> $ grep -r "intel_digital_port \*intel_dig_port" drivers/gpu/drm/i915/
> | wc -l
> 93
> $ grep -r "intel_digital_port \*port" drivers/gpu/drm/i915/ | wc -l
> 11
> $ grep -r "intel_digital_port \*dport" drivers/gpu/drm/i915/ | wc -l
> 18
> 
> > 
> > My main goal here is to prevent the copy-pasters from propagating
> > the
> > call to other parts of the code.
> > 
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_dp.c | 9 +++------
> >  1 file changed, 3 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c
> > b/drivers/gpu/drm/i915/intel_dp.c
> > index ca48bce..6fb90fa 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -4614,14 +4614,11 @@ static bool
> > bdw_digital_port_connected(struct drm_i915_private *dev_priv,
> >  }
> >  
> >  static bool bxt_digital_port_connected(struct drm_i915_private
> > *dev_priv,
> > -				       struct intel_digital_port
> > *intel_dig_port)
> > +				       struct intel_digital_port
> > *port)
> >  {
> > -	struct intel_encoder *intel_encoder = &intel_dig_port-
> > >base;
> > -	enum port port;
> >  	u32 bit;
> >  
> > -	port = intel_hpd_pin_to_port(intel_encoder->hpd_pin);
> > -	switch (port) {
> > +	switch (port->port) {
> >  	case PORT_A:
> >  		bit = BXT_DE_PORT_HP_DDIA;
> >  		break;
> > @@ -4632,7 +4629,7 @@ static bool bxt_digital_port_connected(struct
> > drm_i915_private *dev_priv,
> >  		bit = BXT_DE_PORT_HP_DDIC;
> >  		break;
> >  	default:
> > -		MISSING_CASE(port);
> > +		MISSING_CASE(port->port);
> >  		return false;
> >  	}
> >  
> > -- 
> > 2.9.5
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx