All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bitbake warning fix: No bb files matched BBFILE_PATTERN_packageName
@ 2016-09-27  6:24 Mounesh Sutar
  2016-12-08  6:01 ` Mounesh Sutar
  0 siblings, 1 reply; 6+ messages in thread
From: Mounesh Sutar @ 2016-09-27  6:24 UTC (permalink / raw)
  To: bitbake-devel; +Cc: Mounesh Sutar

From: Mounesh Sutar <mounesh_sutar@mentor.com>

bitbake is parsing all recipe files, against layers BBFILE_PATTERN for warning message display.
In case of sublayer with lower/equal priority, then all sublayer's patterns are not being
considered for pattern match. While checking recipe file against matching pattern,
the first matching pattern is accepted and added to matched list, while remaning PATTERNs are
not being considered. With this, the recipes are being neglected from PATTERN match.
This fix let's parser run through all the layers PATTERNs and on matching added to match list.

Upstream-Status: Submitted [bitbake-devel@lists.openembedded.org]

Signed-off-by: Mounesh Sutar <mounesh_sutar@mentor.com>
---
 bitbake/lib/bb/cooker.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
index 4df8881..5fde995 100644
--- a/bitbake/lib/bb/cooker.py
+++ b/bitbake/lib/bb/cooker.py
@@ -1705,7 +1705,7 @@ class CookerCollectFiles(object):
                 if matched != None:
                     if not regex in matched:
                         matched.add(regex)
-                return pri
+                        return pri
         return 0
 
     def get_bbfiles(self):
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] bitbake warning fix: No bb files matched BBFILE_PATTERN_packageName
@ 2017-10-12 10:57 Mounesh Sutar
  0 siblings, 0 replies; 6+ messages in thread
From: Mounesh Sutar @ 2017-10-12 10:57 UTC (permalink / raw)
  To: bitbake-devel; +Cc: Mounesh Sutar

From: Mounesh Sutar <mounesh_sutar@mentor.com>

bitbake is parsing all recipe files, against layers BBFILE_PATTERN for warning message display.
In case of sublayer with lower/equal priority, then all sublayer's patterns are not being
considered for pattern match. While checking recipe file against matching pattern,
the first matching pattern is accepted and added to matched list, while remaning PATTERNs are
not being considered. With this, the recipes are being neglected from PATTERN match.
This fix let's parser run through all the layers PATTERNs and on matching added to match list.

Signed-off-by: Mounesh Sutar <mounesh_sutar@mentor.com>
---
 bitbake/lib/bb/cooker.py | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
index f44a088..4cf00ee 100644
--- a/bitbake/lib/bb/cooker.py
+++ b/bitbake/lib/bb/cooker.py
@@ -1412,13 +1412,23 @@ class CookerCollectFiles(object):
         self.bbfile_config_priorities = priorities
 
     def calc_bbfile_priority( self, filename, matched = None ):
+        objectInitialised = False
+        tmppri = 0
+        tmpregex = {}
         for _, _, regex, pri in self.bbfile_config_priorities:
-            if regex.match(filename):
-                if matched != None:
-                    if not regex in matched:
-                        matched.add(regex)
-                return pri
-        return 0
+            if regex.match(filename) :
+                if objectInitialised == False:
+                   tmpregex = regex
+                   tmppri = pri
+                   objectInitialised = True
+                else:
+                    if len(regex.pattern) > len(tmpregex.pattern):
+                        tmpregex = regex
+                        tmppri = pri
+        if matched != None:
+            if not tmpregex in matched:
+                matched.add(tmpregex)
+        return tmppri
 
     def get_bbfiles(self):
         """Get list of default .bb files by reading out the current directory"""
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-12 10:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-27  6:24 [PATCH] bitbake warning fix: No bb files matched BBFILE_PATTERN_packageName Mounesh Sutar
2016-12-08  6:01 ` Mounesh Sutar
2017-10-06 20:37   ` Andre McCurdy
2017-10-07 10:01     ` Richard Purdie
2017-10-12 10:13       ` Mounesh Sutar
  -- strict thread matches above, loose matches on Subject: below --
2017-10-12 10:57 Mounesh Sutar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.