From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Sun, 08 Oct 2017 14:21:56 +0000 Subject: Re: [PATCH 0/2] lib: Adjustments for 11 function implementations Message-Id: <1507472516.16112.328.camel@linux.intel.com> List-Id: References: <9a81d82d-fb1b-38d3-1dbf-31e6bf4ff677@users.sourceforge.net> <20171008084224.GA12482@lst.de> In-Reply-To: <20171008084224.GA12482-jcswGhMUV9g@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig , SF Markus Elfring Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML , Will Deacon , "Luis R. Rodriguez" , kasan-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Geert Uytterhoeven , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Alexander Potapenko , Daniel Mentz , Mathieu Desnoyers , Andrey Ryabinin , Andrew Morton , Philipp Reisner , Lars Ellenberg , Dmitry Vyukov On Sun, 2017-10-08 at 10:42 +0200, Christoph Hellwig wrote: > Please stop sending this crap. It's a move from one preference to > another slightly different one. You are free to apply your preference > if you do a major overhaul of some code (subject to maintainer > approval), > but without that they simply are churn. > > NAK for both patches. While patch 1 might have some sense, second one is matter of taste which is dependent to maintainer/trends/weather on Mars. So, +1 to Christoph's opinion. -- Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 0/2] lib: Adjustments for 11 function implementations Date: Sun, 08 Oct 2017 17:21:56 +0300 Message-ID: <1507472516.16112.328.camel@linux.intel.com> References: <9a81d82d-fb1b-38d3-1dbf-31e6bf4ff677@users.sourceforge.net> <20171008084224.GA12482@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171008084224.GA12482-jcswGhMUV9g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Christoph Hellwig , SF Markus Elfring Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML , Will Deacon , "Luis R. Rodriguez" , kasan-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Geert Uytterhoeven , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Alexander Potapenko , Daniel Mentz , Mathieu Desnoyers , Andrey Ryabinin , Andrew Morton , Philipp Reisner , Lars Ellenberg , Dmitry Vyukov List-Id: iommu@lists.linux-foundation.org On Sun, 2017-10-08 at 10:42 +0200, Christoph Hellwig wrote: > Please stop sending this crap. It's a move from one preference to > another slightly different one. You are free to apply your preference > if you do a major overhaul of some code (subject to maintainer > approval), > but without that they simply are churn. > > NAK for both patches. While patch 1 might have some sense, second one is matter of taste which is dependent to maintainer/trends/weather on Mars. So, +1 to Christoph's opinion. -- Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753494AbdJHOXe (ORCPT ); Sun, 8 Oct 2017 10:23:34 -0400 Received: from mga01.intel.com ([192.55.52.88]:43891 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751639AbdJHOXc (ORCPT ); Sun, 8 Oct 2017 10:23:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,495,1500966000"; d="scan'208";a="907909388" Message-ID: <1507472516.16112.328.camel@linux.intel.com> Subject: Re: [PATCH 0/2] lib: Adjustments for 11 function implementations From: Andy Shevchenko To: Christoph Hellwig , SF Markus Elfring Cc: iommu@lists.linux-foundation.org, kasan-dev@googlegroups.com, Alexander Potapenko , Andrew Morton , Andrey Ryabinin , Daniel Mentz , Dmitry Vyukov , Geert Uytterhoeven , Lars Ellenberg , "Luis R. Rodriguez" , Marek Szyprowski , Mathieu Desnoyers , Philipp Reisner , Robin Murphy , Will Deacon , LKML , kernel-janitors@vger.kernel.org Date: Sun, 08 Oct 2017 17:21:56 +0300 In-Reply-To: <20171008084224.GA12482@lst.de> References: <9a81d82d-fb1b-38d3-1dbf-31e6bf4ff677@users.sourceforge.net> <20171008084224.GA12482@lst.de> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.0-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-10-08 at 10:42 +0200, Christoph Hellwig wrote: > Please stop sending this crap. It's a move from one preference to > another slightly different one. You are free to apply your preference > if you do a major overhaul of some code (subject to maintainer > approval), > but without that they simply are churn. > > NAK for both patches. While patch 1 might have some sense, second one is matter of taste which is dependent to maintainer/trends/weather on Mars. So, +1 to Christoph's opinion. -- Andy Shevchenko Intel Finland Oy