From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Mon, 09 Oct 2017 20:20:09 +0000 Subject: Re: [PATCH] kernel/trace: Delete five error messages for a failed memory allocation Message-Id: <1507580409.3552.15.camel@perches.com> List-Id: References: <20171009161337.7c35911f@gandalf.local.home> In-Reply-To: <20171009161337.7c35911f@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Steven Rostedt , SF Markus Elfring Cc: kernel-janitors@vger.kernel.org, Ingo Molnar , LKML On Mon, 2017-10-09 at 16:13 -0400, Steven Rostedt wrote: > On Sat, 7 Oct 2017 16:15:14 +0200 > SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Sat, 7 Oct 2017 16:10:06 +0200 > > > > Omit extra messages for a memory allocation failure in these functions. > > Does memory allocation failures have printk messages? If not, then I > think this is removing useful information. Every k.alloc failure without __GFP_NOWARN does a dump_stack() From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754320AbdJIUUQ (ORCPT ); Mon, 9 Oct 2017 16:20:16 -0400 Received: from smtprelay0189.hostedemail.com ([216.40.44.189]:51833 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754068AbdJIUUP (ORCPT ); Mon, 9 Oct 2017 16:20:15 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2828:2892:2899:3138:3139:3140:3141:3142:3622:3870:3871:3876:4321:5007:7576:10004:10400:10848:10967:11232:11658:11914:12043:12740:12760:12895:13069:13255:13311:13357:13439:14181:14659:14721:21080:21212:21433:21451:21627:30054:30075:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: toad11_3bfa88892351d X-Filterd-Recvd-Size: 1464 Message-ID: <1507580409.3552.15.camel@perches.com> Subject: Re: [PATCH] kernel/trace: Delete five error messages for a failed memory allocation From: Joe Perches To: Steven Rostedt , SF Markus Elfring Cc: kernel-janitors@vger.kernel.org, Ingo Molnar , LKML Date: Mon, 09 Oct 2017 13:20:09 -0700 In-Reply-To: <20171009161337.7c35911f@gandalf.local.home> References: <20171009161337.7c35911f@gandalf.local.home> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-10-09 at 16:13 -0400, Steven Rostedt wrote: > On Sat, 7 Oct 2017 16:15:14 +0200 > SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Sat, 7 Oct 2017 16:10:06 +0200 > > > > Omit extra messages for a memory allocation failure in these functions. > > Does memory allocation failures have printk messages? If not, then I > think this is removing useful information. Every k.alloc failure without __GFP_NOWARN does a dump_stack()