Re: [PATCH] drm/i915: Use execlists_num_ports instead of size of array

From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use execlists_num_ports instead of size of array
Date: Tue, 10 Oct 2017 15:59:24 +0300	[thread overview]
Message-ID: <1507640364.7677.14.camel@linux.intel.com> (raw)
In-Reply-To: <20171010114857.13108-1-mika.kuoppala@intel.com>

On Tue, 2017-10-10 at 14:48 +0300, Mika Kuoppala wrote:
> There is function to tell how many ports we have, so use it.
> We still have direct relationship with array size and port count,
> so no harm was done.
> 
> Fixes: 76e70087d360 ("drm/i915: Make execlist port count variable")
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>

<SNIP>

> +++ b/drivers/gpu/drm/i915/i915_guc_submission.c
> @@ -500,7 +500,7 @@ static void i915_guc_submit(struct intel_engine_cs *engine)
>  	const unsigned int engine_id = engine->id;
>  	unsigned int n;
>  
> -	for (n = 0; n < ARRAY_SIZE(execlists->port); n++) {
> +	for (n = 0; n < execlists_num_ports(execlists); n++) {

For a while I was looking this delta in reverse and could not figure it
out.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx