All of lore.kernel.org
 help / color / mirror / Atom feed
From: <gregkh@linuxfoundation.org>
To: killertofu@gmail.com, gregkh@linuxfoundation.org,
	jason.gerecke@wacom.com, jkosina@suse.cz, ping.cheng@wacom.com
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "HID: wacom: generic: Clear ABS_MISC when tool leaves proximity" has been added to the 4.13-stable tree
Date: Tue, 10 Oct 2017 17:12:54 +0200	[thread overview]
Message-ID: <150764837420512@kroah.com> (raw)


This is a note to let you know that I've just added the patch titled

    HID: wacom: generic: Clear ABS_MISC when tool leaves proximity

to the 4.13-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     hid-wacom-generic-clear-abs_misc-when-tool-leaves-proximity.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 92380b572d95caf48f8424746aeee63c5a2b1922 Mon Sep 17 00:00:00 2001
From: Jason Gerecke <killertofu@gmail.com>
Date: Thu, 7 Sep 2017 17:47:38 -0700
Subject: HID: wacom: generic: Clear ABS_MISC when tool leaves proximity

From: Jason Gerecke <killertofu@gmail.com>

commit 92380b572d95caf48f8424746aeee63c5a2b1922 upstream.

The tool ID information sent in ABS_MISC is expected to be reset to 0
when a tool leaves proximity. Not doing this can cause problems if a
tool is removed and then re-introduced. Kernel event filtering will
prevent the (identical) ABS_MISC event from being sent when the tool
re-enters proxmity. This can cause userspace to not properly set the
tool ID.

Fixes: f85c9dc678 ("HID: wacom: generic: Support tool ID and additional tool types")
Signed-off-by: Ping Cheng <ping.cheng@wacom.com>
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/hid/wacom_wac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/hid/wacom_wac.c
+++ b/drivers/hid/wacom_wac.c
@@ -2272,7 +2272,7 @@ static void wacom_wac_pen_report(struct
 		input_report_key(input, wacom_wac->tool[0], prox);
 		if (wacom_wac->serial[0]) {
 			input_event(input, EV_MSC, MSC_SERIAL, wacom_wac->serial[0]);
-			input_report_abs(input, ABS_MISC, id);
+			input_report_abs(input, ABS_MISC, prox ? id : 0);
 		}
 
 		wacom_wac->hid_data.tipswitch = false;


Patches currently in stable-queue which might be from killertofu@gmail.com are

queue-4.13/hid-wacom-always-increment-hdev-refcount-within-wacom_get_hdev_data.patch
queue-4.13/hid-wacom-correct-coordinate-system-of-touchring-and-pen-twist.patch
queue-4.13/hid-wacom-properly-report-negative-values-from-intuos-pro-2-bluetooth.patch
queue-4.13/hid-wacom-bits-shifted-too-much-for-9th-and-10th-buttons.patch
queue-4.13/hid-wacom-generic-send-msc_serial-and-abs_misc-when-leaving-prox.patch
queue-4.13/hid-wacom-generic-clear-abs_misc-when-tool-leaves-proximity.patch

                 reply	other threads:[~2017-10-10 15:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150764837420512@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jason.gerecke@wacom.com \
    --cc=jkosina@suse.cz \
    --cc=killertofu@gmail.com \
    --cc=ping.cheng@wacom.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.