From: Joe Perches <joe@perches.com>
To: jiang.biao2@zte.com.cn
Cc: apw@canonical.com, linux-kernel@vger.kernel.org,
zhong.weidong@zte.com.cn
Subject: Re: [PATCH] scripts/checkpatch.pl: fix false warning of externschecking.
Date: Tue, 10 Oct 2017 20:29:09 -0700 [thread overview]
Message-ID: <1507692549.3552.43.camel@perches.com> (raw)
In-Reply-To: <201710111121397732689@zte.com.cn>
On Wed, 2017-10-11 at 11:21 +0800, jiang.biao2@zte.com.cn wrote:
> > On Tue, 2017-10-10 at 16:42 +0800, Jiang Biao wrote:
> > > When adding a function declaration in a .c file without an extern
> > > keywork decoration, checkpatch.pl will complain *externs should be
> > > avoided in .c files* false warning. This patch fix the bug.
> > nack.
> > The point is that external function declarations should be
> > done via #include.
> Hi Joe,
Hello Jiang
> Understood. But there are already some external function declarations in
> .c files in current kernel, for instance line 505 in kernel/stop_machine.c,
>
> extern void sched_set_stop_task(int cpu, struct task_struct *stop);
>
> Should these be fixed? But maybe in some rare cases, external funciton
> declarations in .c files are necessary.
Perhaps, but in those cases checkpatch messages should be ignored.
cheers, Joe
parent reply other threads:[~2017-10-11 3:29 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <201710111121397732689@zte.com.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507692549.3552.43.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=jiang.biao2@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.