From: Rik van Riel <riel@surriel.com>
To: Gargi Sharma <gs051095@gmail.com>, linux-kernel@vger.kernel.org
Cc: julia.lawall@lip6.fr, akpm@linux-foundation.org,
mingo@kernel.org, pasha.tatashin@oracle.com,
ktkhai@virtuozzo.com, oleg@redhat.com, ebiederm@xmission.com,
hch@infradead.org, lkp@intel.com, tony.luck@intel.com
Subject: Re: [PATCH v6 1/2] pid: Replace pid bitmap implementation with IDR API
Date: Wed, 11 Oct 2017 18:28:09 -0400 [thread overview]
Message-ID: <1507760889.21121.190.camel@surriel.com> (raw)
In-Reply-To: <1507760379-21662-2-git-send-email-gs051095@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
On Wed, 2017-10-11 at 18:19 -0400, Gargi Sharma wrote:
> This patch replaces the current bitmap implemetation for
> Process ID allocation. Functions that are no longer required,
> for example, free_pidmap(), alloc_pidmap(), etc. are removed.
> The rest of the functions are modified to use the IDR API.
> The change was made to make the PID allocation less complex by
> replacing custom code with calls to generic API.
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
> arch/powerpc/platforms/cell/spufs/sched.c | 2 +-
> fs/proc/loadavg.c | 2 +-
> include/linux/pid_namespace.h | 14 +--
> init/main.c | 2 +-
> kernel/pid.c | 201 ++++++------------
> ------------
> kernel/pid_namespace.c | 44 +++----
> 6 files changed, 57 insertions(+), 208 deletions(-)
I'm all out of nitpicks now :)
Also, I really love that diffstat.
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2017-10-11 22:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 22:19 [PATCH v6 0/2] Replacing PID bitmap implementation with IDR API Gargi Sharma
2017-10-11 22:19 ` [PATCH v6 1/2] pid: Replace pid " Gargi Sharma
2017-10-11 22:28 ` Rik van Riel [this message]
2017-10-11 22:37 ` Andrew Morton
2017-10-12 0:54 ` Rik van Riel
2017-10-12 22:58 ` Andrew Morton
2017-10-13 14:58 ` Oleg Nesterov
2017-10-19 7:30 ` [v6,1/2] " Andrei Vagin
2017-10-19 13:20 ` Gargi Sharma
2017-10-19 16:18 ` Oleg Nesterov
2017-10-20 16:06 ` Gargi Sharma
2017-10-20 17:21 ` Andrei Vagin
2017-10-22 8:05 ` Gargi Sharma
2017-10-23 15:31 ` Oleg Nesterov
2017-10-11 22:19 ` [PATCH v6 2/2] pid: Remove pidhash Gargi Sharma
2017-10-11 22:28 ` Rik van Riel
2017-10-11 22:47 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507760889.21121.190.camel@surriel.com \
--to=riel@surriel.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gs051095@gmail.com \
--cc=hch@infradead.org \
--cc=julia.lawall@lip6.fr \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=pasha.tatashin@oracle.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.