From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Sagar Arun Kamble <sagar.a.kamble@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/1] drm/i915: Split i915_gem_suspend into user quiescing and HW cleanup/suspend
Date: Thu, 12 Oct 2017 12:13:38 +0300 [thread overview]
Message-ID: <1507799618.5138.30.camel@linux.intel.com> (raw)
In-Reply-To: <935932d5-853c-3937-1f22-df9aa8504a41@intel.com>
On Fri, 2017-10-06 at 13:39 +0530, Sagar Arun Kamble wrote:
>
> On 10/6/2017 12:07 PM, Sagar Arun Kamble wrote:
> > GTT mappings are to be suspended post i915_gem_suspend and display
>
> I think I should say this "post idling GPU and display suspend". Will
> update in next rev.
> > suspend. GPU is reset in i915_gem_suspend. This separated the HW suspend
> > across reset. To achieve the complete HW cleanup prior to GPU reset we
> > need to separate i915_gem_suspend functionality into user quiescing
> > and HW cleanup. With this patch new function i915_gem_quiescent
>
> And this should have been named "i915_gem_quiesce"?
> Chris, Joonas, does i915_gem_quiesce for user quiescing and
> i915_gem_suspend for HW suspend look good?
The BAT results seemed quite negative.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-12 9:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 18:07 [PATCH 1/1] drm/i915: Move i915_gem_suspend_gtt_mappings to i915_gem_suspend Sagar Arun Kamble
2017-10-05 18:11 ` Chris Wilson
2017-10-05 18:17 ` Sagar Arun Kamble
2017-10-05 18:22 ` Chris Wilson
2017-10-05 18:30 ` Sagar Arun Kamble
2017-10-06 6:37 ` [PATCH v2 1/1] drm/i915: Split i915_gem_suspend into user quiescing and HW cleanup/suspend Sagar Arun Kamble
2017-10-06 8:09 ` Sagar Arun Kamble
2017-10-12 9:13 ` Joonas Lahtinen [this message]
2017-10-12 9:18 ` Sagar Arun Kamble
2017-10-06 11:25 ` ✗ Fi.CI.BAT: failure for series starting with [v2,1/1] drm/i915: Split i915_gem_suspend into user quiescing and HW cleanup/suspend (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507799618.5138.30.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sagar.a.kamble@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.