From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] usb-ccid: remove needless migration state code
Date: Thu, 12 Oct 2017 15:29:15 +0200 [thread overview]
Message-ID: <1507814955.24675.1.camel@redhat.com> (raw)
In-Reply-To: <20171012112157.15647-1-marcandre.lureau@redhat.com>
On Thu, 2017-10-12 at 13:21 +0200, Marc-André Lureau wrote:
> This code appears to be unused since its introduction. It should be
> safe to remove from VMState.
Well, almost:
> @@ -1452,7 +1431,6 @@ static VMStateDescription ccid_vmstate = {
> VMSTATE_STRUCT_ARRAY(pending_answers, USBCCIDState,
> PENDING_ANSWERS_NUM, 1, answer_vmstate,
> Answer),
> VMSTATE_UINT32(pending_answers_num, USBCCIDState),
> - VMSTATE_UINT8(migration_state, USBCCIDState),
> VMSTATE_UINT32(state_vmstate, USBCCIDState),
> VMSTATE_END_OF_LIST()
> }
We have to keep this (or some placeholder) so the vmstate format
doesn't change.
cheers,
Gerd
next prev parent reply other threads:[~2017-10-12 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 11:21 [Qemu-devel] [PATCH] usb-ccid: remove needless migration state code Marc-André Lureau
2017-10-12 13:29 ` Gerd Hoffmann [this message]
2017-10-12 14:02 ` Marc-André Lureau
2017-10-12 15:04 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507814955.24675.1.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.