From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trent Piepho Subject: [PATCH 1/4] spi: imx: GPIO based chip selects should not be required Date: Fri, 13 Oct 2017 18:22:01 +0000 Message-ID: <1507918921.24265.8.camel@impinj.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , "gerg-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org" , "fabio.estevam-3arQi8VN3Tc@public.gmane.org" To: "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" Return-path: Content-Language: en-US Content-ID: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: VGhlIGRyaXZlciB3aWxsIGZhaWwgdG8gbG9hZCBpZiBubyBncGlvIGNoaXAgc2VsZWN0cyBhcmUg c3BlY2lmaWVkLA0KdGhpcyBwYXRjaCBjaGFuZ2VzIHRoaXMgc28gdGhhdCBpdCBubyBsb25nZXIg ZmFpbHMuDQoNCkl0J3MgcG9zc2libGUgdG8gdXNlIGFsbCBuYXRpdmUgY2hpcCBzZWxlY3RzLCBp biB3aGljaCBjYXNlIHRoZXJlIGlzDQpubyByZWFzb24gdG8gaGF2ZSBhIGdwaW8gY2hpcCBzZWxl Y3QgYXJyYXkuICBUaGlzIGlzIHdoYXQgaGFwcGVucyBpZg0KdGhlICpvcHRpb25hbCogZGV2aWNl IHRyZWUgcHJvcGVydHkgImNzLWdwaW9zIiBpcyBvbWl0dGVkLg0KDQpUaGUgc3BpIGNvcmUgYWxy ZWFkeSBjaGVja3MgZm9yIHRoZSBhYnNlbmNlIG9mIGdwaW8gY2hpcCBzZWxlY3RzIGluDQp0aGUg bWFzdGVyIGFuZCBhc3NpZ25zIGFueSBzbGF2ZXMgdGhlIGdwaW9fY3MgdmFsdWUgb2YgLUVOT0VO VC4NCg0KU2lnbmVkLW9mZi1ieTogVHJlbnQgUGllcGhvIDx0cGllcGhvQGltcGluai5jb20+DQot LS0NCiBkcml2ZXJzL3NwaS9zcGktaW14LmMgfCAyOSArKysrKysrKysrKysrLS0tLS0tLS0tLS0t LS0tLQ0KIDEgZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkN Cg0KZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3BpL3NwaS1pbXguYyBiL2RyaXZlcnMvc3BpL3NwaS1p bXguYw0KaW5kZXggYmFiYjE1ZjA3OTk1Li4wN2U2MjUwZjJkYWQgMTAwNjQ0DQotLS0gYS9kcml2 ZXJzL3NwaS9zcGktaW14LmMNCisrKyBiL2RyaXZlcnMvc3BpL3NwaS1pbXguYw0KQEAgLTE0NTcs MjIgKzE0NTcsMTkgQEAgc3RhdGljIGludCBzcGlfaW14X3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9k ZXZpY2UgKnBkZXYpDQogCQlnb3RvIG91dF9jbGtfcHV0Ow0KIAl9DQogDQotCWlmICghbWFzdGVy LT5jc19ncGlvcykgew0KLQkJZGV2X2VycigmcGRldi0+ZGV2LCAiTm8gQ1MgR1BJT3MgYXZhaWxh YmxlXG4iKTsNCi0JCXJldCA9IC1FSU5WQUw7DQotCQlnb3RvIG91dF9jbGtfcHV0Ow0KLQl9DQot DQotCWZvciAoaSA9IDA7IGkgPCBtYXN0ZXItPm51bV9jaGlwc2VsZWN0OyBpKyspIHsNCi0JCWlm ICghZ3Bpb19pc192YWxpZChtYXN0ZXItPmNzX2dwaW9zW2ldKSkNCi0JCQljb250aW51ZTsNCi0N Ci0JCXJldCA9IGRldm1fZ3Bpb19yZXF1ZXN0KCZwZGV2LT5kZXYsIG1hc3Rlci0+Y3NfZ3Bpb3Nb aV0sDQotCQkJCQlEUklWRVJfTkFNRSk7DQotCQlpZiAocmV0KSB7DQotCQkJZGV2X2VycigmcGRl di0+ZGV2LCAiQ2FuJ3QgZ2V0IENTIEdQSU8gJWlcbiIsDQotCQkJCW1hc3Rlci0+Y3NfZ3Bpb3Nb aV0pOw0KLQkJCWdvdG8gb3V0X2Nsa19wdXQ7DQorCS8qIFJlcXVlc3QgR1BJTyBDUyBsaW5lcywg aWYgYW55ICovDQorCWlmIChtYXN0ZXItPmNzX2dwaW9zKSB7DQorCQlmb3IgKGkgPSAwOyBpIDwg bWFzdGVyLT5udW1fY2hpcHNlbGVjdDsgaSsrKSB7DQorCQkJaWYgKCFncGlvX2lzX3ZhbGlkKG1h c3Rlci0+Y3NfZ3Bpb3NbaV0pKQ0KKwkJCQljb250aW51ZTsNCisNCisJCQlyZXQgPSBkZXZtX2dw aW9fcmVxdWVzdCgmcGRldi0+ZGV2LCBtYXN0ZXItPmNzX2dwaW9zW2ldLA0KKwkJCQkJCURSSVZF Ul9OQU1FKTsNCisJCQlpZiAocmV0KSB7DQorCQkJCWRldl9lcnIoJnBkZXYtPmRldiwgIkNhbid0 IGdldCBDUyBHUElPICVpXG4iLA0KKwkJCQkJbWFzdGVyLT5jc19ncGlvc1tpXSk7DQorCQkJCWdv dG8gb3V0X2Nsa19wdXQ7DQorCQkJfQ0KIAkJfQ0KIAl9DQogDQotLSANCjIuMTMuNg0K -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: tpiepho@impinj.com (Trent Piepho) Date: Fri, 13 Oct 2017 18:22:01 +0000 Subject: [PATCH 1/4] spi: imx: GPIO based chip selects should not be required Message-ID: <1507918921.24265.8.camel@impinj.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org The driver will fail to load if no gpio chip selects are specified, this patch changes this so that it no longer fails. It's possible to use all native chip selects, in which case there is no reason to have a gpio chip select array. This is what happens if the *optional* device tree property "cs-gpios" is omitted. The spi core already checks for the absence of gpio chip selects in the master and assigns any slaves the gpio_cs value of -ENOENT. Signed-off-by: Trent Piepho --- drivers/spi/spi-imx.c | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index babb15f07995..07e6250f2dad 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -1457,22 +1457,19 @@ static int spi_imx_probe(struct platform_device *pdev) goto out_clk_put; } - if (!master->cs_gpios) { - dev_err(&pdev->dev, "No CS GPIOs available\n"); - ret = -EINVAL; - goto out_clk_put; - } - - for (i = 0; i < master->num_chipselect; i++) { - if (!gpio_is_valid(master->cs_gpios[i])) - continue; - - ret = devm_gpio_request(&pdev->dev, master->cs_gpios[i], - DRIVER_NAME); - if (ret) { - dev_err(&pdev->dev, "Can't get CS GPIO %i\n", - master->cs_gpios[i]); - goto out_clk_put; + /* Request GPIO CS lines, if any */ + if (master->cs_gpios) { + for (i = 0; i < master->num_chipselect; i++) { + if (!gpio_is_valid(master->cs_gpios[i])) + continue; + + ret = devm_gpio_request(&pdev->dev, master->cs_gpios[i], + DRIVER_NAME); + if (ret) { + dev_err(&pdev->dev, "Can't get CS GPIO %i\n", + master->cs_gpios[i]); + goto out_clk_put; + } } } -- 2.13.6