From: <gregkh@linuxfoundation.org>
To: johan@kernel.org, andreyknvl@google.com, gregkh@linuxfoundation.org
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "USB: serial: console: fix use-after-free on disconnect" has been added to the 4.13-stable tree
Date: Sun, 15 Oct 2017 16:07:08 +0200 [thread overview]
Message-ID: <15080764281174@kroah.com> (raw)
This is a note to let you know that I've just added the patch titled
USB: serial: console: fix use-after-free on disconnect
to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-serial-console-fix-use-after-free-on-disconnect.patch
and it can be found in the queue-4.13 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From bd998c2e0df0469707503023d50d46cf0b10c787 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Wed, 4 Oct 2017 11:01:12 +0200
Subject: USB: serial: console: fix use-after-free on disconnect
From: Johan Hovold <johan@kernel.org>
commit bd998c2e0df0469707503023d50d46cf0b10c787 upstream.
A clean-up patch removing two redundant NULL-checks from the console
disconnect handler inadvertently also removed a third check. This could
lead to the struct usb_serial being prematurely freed by the console
code when a driver accepts but does not register any ports for an
interface which also lacks endpoint descriptors.
Fixes: 0e517c93dc02 ("USB: serial: console: clean up sanity checks")
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/serial/console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/serial/console.c
+++ b/drivers/usb/serial/console.c
@@ -265,7 +265,7 @@ static struct console usbcons = {
void usb_serial_console_disconnect(struct usb_serial *serial)
{
- if (serial->port[0] == usbcons_info.port) {
+ if (serial->port[0] && serial->port[0] == usbcons_info.port) {
usb_serial_console_exit();
usb_serial_put(serial);
}
Patches currently in stable-queue which might be from johan@kernel.org are
queue-4.13/usb-serial-console-fix-use-after-free-on-disconnect.patch
queue-4.13/alsa-caiaq-fix-stray-urb-at-probe-error-path.patch
queue-4.13/usb-serial-cp210x-fix-partnum-regression.patch
queue-4.13/usb-serial-option-add-support-for-tp-link-lte-module.patch
queue-4.13/usb-serial-cp210x-add-support-for-elv-tfd500.patch
queue-4.13/usb-serial-qcserial-add-dell-dw5818-dw5819.patch
queue-4.13/usb-serial-console-fix-use-after-free-after-failed-setup.patch
queue-4.13/usb-serial-ftdi_sio-add-id-for-cypress-wiced-dev-board.patch
reply other threads:[~2017-10-15 14:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15080764281174@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreyknvl@google.com \
--cc=johan@kernel.org \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.