From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v4 07/14] drm/i915/guc: Move firmware size check out of generic code
Date: Mon, 16 Oct 2017 15:45:52 +0300 [thread overview]
Message-ID: <1508157952.5300.41.camel@linux.intel.com> (raw)
In-Reply-To: <20171013111137.32692-8-michal.wajdeczko@intel.com>
On Fri, 2017-10-13 at 11:11 +0000, Michal Wajdeczko wrote:
> Checking GuC firmware size can be done in GuC specific code
> right before DMA copy as it is unlikely to fail anyway.
>
> v2: rebased
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com> #1
<SNIP>
So, lets move this code under the "uc_fw->ucode_size = (css->size_dw -
css->header_size_dw) * sizeof(u32);" line and consider any firmware
with conflicting information a corrupt file.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-16 12:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 11:11 [PATCH v4 00/14] Firmware code reorg Michal Wajdeczko
2017-10-13 11:11 ` [PATCH v4 01/14] drm/i915: Move intel_guc_wopcm_size to intel_guc.c Michal Wajdeczko
2017-10-13 11:11 ` [PATCH v4 02/14] drm/i915/guc: Move GuC boot param initialization out of xfer Michal Wajdeczko
2017-10-13 11:11 ` [PATCH v4 03/14] drm/i915/guc: Small fixups post code move Michal Wajdeczko
2017-10-13 11:11 ` [PATCH v4 04/14] drm/i915/guc: Move doc near related definitions Michal Wajdeczko
2017-10-13 11:11 ` [PATCH v4 05/14] drm/i915/guc: Rename intel_guc_loader.c to intel_guc_fw.c Michal Wajdeczko
2017-10-13 11:11 ` [PATCH v4 06/14] drm/i915/guc: Reorder functions in intel_guc_fw.c Michal Wajdeczko
2017-10-13 11:11 ` [PATCH v4 07/14] drm/i915/guc: Move firmware size check out of generic code Michal Wajdeczko
2017-10-16 12:45 ` Joonas Lahtinen [this message]
2017-10-13 11:11 ` [PATCH v4 08/14] drm/i915/guc: Pick better place for Guc final status message Michal Wajdeczko
2017-10-13 11:11 ` [PATCH v4 09/14] drm/i915/uc: Improve debug messages in firmware fetch Michal Wajdeczko
2017-10-13 11:11 ` [PATCH v4 10/14] drm/i915/uc: Add message with firmware url Michal Wajdeczko
2017-10-13 11:50 ` Chris Wilson
2017-10-13 11:52 ` Chris Wilson
2017-10-13 11:11 ` [PATCH v4 11/14] drm/i915: Update DMC firmware load error messages Michal Wajdeczko
2017-10-13 11:54 ` Chris Wilson
2017-10-13 11:11 ` [PATCH v4 12/14] drm/i915/uc: Unify firmware loading Michal Wajdeczko
2017-10-13 11:11 ` [PATCH v4 13/14] drm/i915/guc: Update Guc messages on load failure Michal Wajdeczko
2017-10-13 11:11 ` [PATCH v4 14/14] drm/i915/huc: Move fw select function Michal Wajdeczko
2017-10-13 11:47 ` ✓ Fi.CI.BAT: success for Firmware code reorg (rev3) Patchwork
2017-10-13 14:46 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508157952.5300.41.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.