From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755638AbdJPTqL (ORCPT <rfc822;w@1wt.eu>);
        Mon, 16 Oct 2017 15:46:11 -0400
Received: from imap1.codethink.co.uk ([176.9.8.82]:58628 "EHLO
        imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753200AbdJPTqK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 16 Oct 2017 15:46:10 -0400
Message-ID: <1508183166.22379.41.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 15/50] tty: goldfish: Fix a parameter of a call to
 free_irq
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Sasha Levin <alexander.levin@verizon.com>
Date: Mon, 16 Oct 2017 20:46:06 +0100
In-Reply-To: <20171006083707.525851713@linuxfoundation.org>
References: <20171006083705.157012217@linuxfoundation.org>
         <20171006083707.525851713@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6-1+deb9u1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2017-10-06 at 10:53 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me
> know.
> 
> ------------------
> 
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> 
> [ Upstream commit 1a5c2d1de7d35f5eb9793266237903348989502b ]
> 
> 'request_irq()' and 'free_irq()' should be called with the same
> dev_id.
[...]

This fixes a bug introduced in 4.6 by commit 465893e18878 "tty:
goldfish: support platform_device with id -1".  For earlier kernel
versions, it *introduces* a bug.

Please revert from the 3.18 and 4.4 branches.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.