Re: [PATCH v4 4/5] xentrace: enable per-VCPU extratime flag for RTDS

[Dario Faggioli <raistlin@linux.it>]

[-- Attachment #1.1: Type: text/plain, Size: 1227 bytes --]

On Wed, 2017-10-11 at 14:02 -0400, Meng Xu wrote:
> Change repl_budget event output for xentrace formats and xenalyze
> 
> Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> 
I'd say:

Reviewed-by: Dario Faggioli <raistlin@linux.it>

However...

> diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
> index 79bdba7..19e050f 100644
> --- a/tools/xentrace/xenalyze.c
> +++ b/tools/xentrace/xenalyze.c
> @@ -7935,23 +7935,29 @@ void sched_process(struct pcpu_info *p)
>                      unsigned int vcpuid:16, domid:16;
>                      uint64_t cur_bg;
>                      int delta;
> +                    unsigned priority_level;
> +                    unsigned has_extratime;
>
...this last field is 'bool' in Xen.

I appreciate that xenalyze does not build if you just make this bool as
well. But it does build for me, if you do that, and also include
stdbool.h, which I think is a fine thing to do.

Anyway, I'll leave this to George and tools' maintainers.

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel