From: Johannes Berg <johannes@sipsolutions.net>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
make-wifi-fast@lists.bufferbloat.net,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: Add airtime accounting and scheduling to TXQs
Date: Tue, 17 Oct 2017 12:00:43 +0200 [thread overview]
Message-ID: <1508234443.10607.72.camel@sipsolutions.net> (raw)
In-Reply-To: <871sm2p6rt.fsf@toke.dk>
On Tue, 2017-10-17 at 09:34 +0200, Toke Høiland-Jørgensen wrote:
> Yeah, I did that initially. The reason I ended up squashing them is
> that
> this patch moved the per-station 'airtime' debugfs-entry that was
> previously created by ath9k into mac80211. I assumed it would create
> problems if both the driver and mac80211 tried to create the same
> file;
> not sure how to handle that if it's split into two patches?
That might indeed be problematic, so perhaps just use a different name?
Then again, if adding the entry fails in ath9k, nothing will happen
since it doesn't even check the return value - so I think it doesn't
actually matter.
> > I'd prefer this were called "airtime" or such,
>
> Right. I picked rx_time for symmetry with the tx side; should I
> rename that as well, then, or is asymmetry fine?
Let's not change the tx side in this patch, but we can clean it up
later I guess.
johannes
next prev parent reply other threads:[~2017-10-17 10:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 16:09 [PATCH 1/2] mac80211: Add TXQ scheduling API Toke Høiland-Jørgensen
2017-10-16 16:09 ` [PATCH 2/2] mac80211: Add airtime accounting and scheduling to TXQs Toke Høiland-Jørgensen
2017-10-17 7:07 ` Johannes Berg
2017-10-17 7:34 ` Toke Høiland-Jørgensen
2017-10-17 10:00 ` Johannes Berg [this message]
2017-10-17 10:09 ` Toke Høiland-Jørgensen
2017-10-17 6:39 ` [PATCH 1/2] mac80211: Add TXQ scheduling API Johannes Berg
2017-10-27 14:14 ` [PATCH v2 1/3] " Toke Høiland-Jørgensen
2017-10-31 0:14 ` kbuild test robot
2017-10-31 0:45 ` kbuild test robot
2017-10-31 11:27 ` [PATCH v3 " Toke Høiland-Jørgensen
2017-12-14 11:33 ` Felix Fietkau
2017-12-14 12:15 ` Toke Høiland-Jørgensen
2017-12-14 12:44 ` Felix Fietkau
2017-12-14 14:34 ` Toke Høiland-Jørgensen
2017-12-19 9:44 ` Johannes Berg
2017-10-31 11:27 ` [PATCH v3 2/3] mac80211: Add airtime account and scheduling to TXQs Toke Høiland-Jørgensen
2017-10-31 11:27 ` [PATCH v3 3/3] ath9k: Switch to mac80211 airtime API Toke Høiland-Jørgensen
2017-10-27 14:14 ` [PATCH v2 2/3] mac80211: Add airtime account and scheduling to TXQs Toke Høiland-Jørgensen
2017-10-27 14:14 ` [PATCH v2 3/3] ath9k: Switch to mac80211 airtime API Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508234443.10607.72.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.