diff for duplicates of <1508246223.3477.28.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index eb41c7e..06ec4c7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,18 +1,32 @@ -T24gVHVlLCAyMDE3LTEwLTE3IGF0IDE1OjMzICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K -PiBUaGVyZSBpcyBhIHByb2JsZW0gd2hlbiB3ZSBkbzoNCj4gDQo+IAlzZXF1ZW5jZSA9IHBrZy0+ -aGRyLmxlbmd0aF9zbiAmIFRCSVBfSERSX1NOX01BU0s7DQo+IAlzZXF1ZW5jZSA+Pj0gVEJJUF9I -RFJfU05fU0hJRlQ7DQo+IA0KPiBUQklQX0hEUl9TTl9TSElGVCBpcyAyNywgYW5kIHJpZ2h0IHNo -aWZ0aW5nIGEgdTggMjcgYml0cyBpcyBhbHdheXMNCj4gZ29pbmcgdG8gcmVzdWx0IGluIHplcm8u -wqDCoFRoZSBmaXggaXMgdG8gZGVjbGFyZSB0aGVzZSB2YXJpYWJsZXMgYXMNCj4gdTMyLg0KPiAN -Cj4gRml4ZXM6IGU2OWI2YzAyYjRjMyAoIm5ldDogQWRkIHN1cHBvcnQgZm9yIG5ldHdvcmtpbmcg -b3Zlcg0KPiBUaHVuZGVyYm9sdCBjYWJsZSIpDQo+IFNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50 -ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4NCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJz -L25ldC90aHVuZGVyYm9sdC5jIGIvZHJpdmVycy9uZXQvdGh1bmRlcmJvbHQuYw0KPiBpbmRleCAx -YTdiYzBiZjQ1OTguLjQzNTg1NDY4OGE3YSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9uZXQvdGh1 -bmRlcmJvbHQuYw0KPiArKysgYi9kcml2ZXJzL25ldC90aHVuZGVyYm9sdC5jDQo+IEBAIC0zOTQs -NyArMzk0LDcgQEAgc3RhdGljIGludCB0Ym5ldF9oYW5kbGVfcGFja2V0KGNvbnN0IHZvaWQgKmJ1 -ZiwNCj4gc2l6ZV90IHNpemUsIHZvaWQgKmRhdGEpDQo+IMKgCXN0cnVjdCB0Ym5ldCAqbmV0ID0g -ZGF0YTsNCj4gwqAJdTMyIGNvbW1hbmRfaWQ7DQo+IMKgCWludCByZXQgPSAwOw0KPiAtCXU4IHNl -cXVlbmNlOw0KPiArCXUzMiBzZXF1ZW5jZTsNCj4gwqAJdTY0IHJvdXRlOw0KPiDCoA0KPiDCoAkv -KiBNYWtlIHN1cmUgdGhlIHBhY2tldCBpcyBmb3IgdXMgKi8NCg0KQWNrZWQtYnk6IFllaGV6a2Vs -IEJlcm5hdCA8eWVoZXprZWwuYmVybmF0QGludGVsLmNvbT4NCg0KVGhhbmtzIQ0K +On Tue, 2017-10-17 at 15:33 +0300, Dan Carpenter wrote: +> There is a problem when we do: +> +> sequence = pkg->hdr.length_sn & TBIP_HDR_SN_MASK; +> sequence >>= TBIP_HDR_SN_SHIFT; +> +> TBIP_HDR_SN_SHIFT is 27, and right shifting a u8 27 bits is always +> going to result in zero. The fix is to declare these variables as +> u32. +> +> Fixes: e69b6c02b4c3 ("net: Add support for networking over +> Thunderbolt cable") +> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> +> +> diff --git a/drivers/net/thunderbolt.c b/drivers/net/thunderbolt.c +> index 1a7bc0bf4598..435854688a7a 100644 +> --- a/drivers/net/thunderbolt.c +> +++ b/drivers/net/thunderbolt.c +> @@ -394,7 +394,7 @@ static int tbnet_handle_packet(const void *buf, +> size_t size, void *data) +> struct tbnet *net = data; +> u32 command_id; +> int ret = 0; +> - u8 sequence; +> + u32 sequence; +> u64 route; +> +> /* Make sure the packet is for us */ + +Acked-by: Yehezkel Bernat <yehezkel.bernat@intel.com> + +Thanks! diff --git a/a/content_digest b/N1/content_digest index 973c567..5628256 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -13,23 +13,37 @@ " kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gVHVlLCAyMDE3LTEwLTE3IGF0IDE1OjMzICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K\n" - "PiBUaGVyZSBpcyBhIHByb2JsZW0gd2hlbiB3ZSBkbzoNCj4gDQo+IAlzZXF1ZW5jZSA9IHBrZy0+\n" - "aGRyLmxlbmd0aF9zbiAmIFRCSVBfSERSX1NOX01BU0s7DQo+IAlzZXF1ZW5jZSA+Pj0gVEJJUF9I\n" - "RFJfU05fU0hJRlQ7DQo+IA0KPiBUQklQX0hEUl9TTl9TSElGVCBpcyAyNywgYW5kIHJpZ2h0IHNo\n" - "aWZ0aW5nIGEgdTggMjcgYml0cyBpcyBhbHdheXMNCj4gZ29pbmcgdG8gcmVzdWx0IGluIHplcm8u\n" - "wqDCoFRoZSBmaXggaXMgdG8gZGVjbGFyZSB0aGVzZSB2YXJpYWJsZXMgYXMNCj4gdTMyLg0KPiAN\n" - "Cj4gRml4ZXM6IGU2OWI2YzAyYjRjMyAoIm5ldDogQWRkIHN1cHBvcnQgZm9yIG5ldHdvcmtpbmcg\n" - "b3Zlcg0KPiBUaHVuZGVyYm9sdCBjYWJsZSIpDQo+IFNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50\n" - "ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4NCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJz\n" - "L25ldC90aHVuZGVyYm9sdC5jIGIvZHJpdmVycy9uZXQvdGh1bmRlcmJvbHQuYw0KPiBpbmRleCAx\n" - "YTdiYzBiZjQ1OTguLjQzNTg1NDY4OGE3YSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9uZXQvdGh1\n" - "bmRlcmJvbHQuYw0KPiArKysgYi9kcml2ZXJzL25ldC90aHVuZGVyYm9sdC5jDQo+IEBAIC0zOTQs\n" - "NyArMzk0LDcgQEAgc3RhdGljIGludCB0Ym5ldF9oYW5kbGVfcGFja2V0KGNvbnN0IHZvaWQgKmJ1\n" - "ZiwNCj4gc2l6ZV90IHNpemUsIHZvaWQgKmRhdGEpDQo+IMKgCXN0cnVjdCB0Ym5ldCAqbmV0ID0g\n" - "ZGF0YTsNCj4gwqAJdTMyIGNvbW1hbmRfaWQ7DQo+IMKgCWludCByZXQgPSAwOw0KPiAtCXU4IHNl\n" - "cXVlbmNlOw0KPiArCXUzMiBzZXF1ZW5jZTsNCj4gwqAJdTY0IHJvdXRlOw0KPiDCoA0KPiDCoAkv\n" - "KiBNYWtlIHN1cmUgdGhlIHBhY2tldCBpcyBmb3IgdXMgKi8NCg0KQWNrZWQtYnk6IFllaGV6a2Vs\n" - IEJlcm5hdCA8eWVoZXprZWwuYmVybmF0QGludGVsLmNvbT4NCg0KVGhhbmtzIQ0K + "On Tue, 2017-10-17 at 15:33 +0300, Dan Carpenter wrote:\n" + "> There is a problem when we do:\n" + "> \n" + "> \tsequence = pkg->hdr.length_sn & TBIP_HDR_SN_MASK;\n" + "> \tsequence >>= TBIP_HDR_SN_SHIFT;\n" + "> \n" + "> TBIP_HDR_SN_SHIFT is 27, and right shifting a u8 27 bits is always\n" + "> going to result in zero.\302\240\302\240The fix is to declare these variables as\n" + "> u32.\n" + "> \n" + "> Fixes: e69b6c02b4c3 (\"net: Add support for networking over\n" + "> Thunderbolt cable\")\n" + "> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" + "> \n" + "> diff --git a/drivers/net/thunderbolt.c b/drivers/net/thunderbolt.c\n" + "> index 1a7bc0bf4598..435854688a7a 100644\n" + "> --- a/drivers/net/thunderbolt.c\n" + "> +++ b/drivers/net/thunderbolt.c\n" + "> @@ -394,7 +394,7 @@ static int tbnet_handle_packet(const void *buf,\n" + "> size_t size, void *data)\n" + "> \302\240\tstruct tbnet *net = data;\n" + "> \302\240\tu32 command_id;\n" + "> \302\240\tint ret = 0;\n" + "> -\tu8 sequence;\n" + "> +\tu32 sequence;\n" + "> \302\240\tu64 route;\n" + "> \302\240\n" + "> \302\240\t/* Make sure the packet is for us */\n" + "\n" + "Acked-by: Yehezkel Bernat <yehezkel.bernat@intel.com>\n" + "\n" + Thanks! -d6ac318279185e9315afeb21cbaf48ef9e40052bcf7f7b8ab94f43582e6cf4c5 +31ee398dc094a867807aea7778bc5ad86976691006a73c58505cc701f4fc5b35
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.