From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Tue, 17 Oct 2017 22:43:30 +0000 Subject: Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations Message-Id: <1508280210.6530.32.camel@perches.com> List-Id: References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <20171016183139.otyh3m5c5yurtmow@linux.intel.com> <20171016183512.3bz6x4b6lbhpbkje@linux.intel.com> <20171017085124.pkrjzghcf5wmcydc@mwanda> <1508255833.3129.33.camel@HansenPartnership.com> In-Reply-To: <1508255833.3129.33.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: James Bottomley , SF Markus Elfring , Dan Carpenter , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Jarkko Sakkinen , Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , Peter =?ISO-8859-1?Q?H=FCwe?= , Stefan Berger , LKML , kernel-janitors@vger.kernel.org On Tue, 2017-10-17 at 08:57 -0700, James Bottomley wrote: > On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote: > > >=20 > > > Fixes is only for bug fixes.=A0=A0These don't fix any bugs. > >=20 > > How do you distinguish these in questionable source code > > from other error categories or software weaknesses? >=20 > A style change is one that doesn't change the effect of the execution. > =A0These don't actually even change the assembly, so there's programmatic > proof they're not fixing anything. The printk removals do change the objects. The value of that type of change is only for resource limited systems. printk type changes should generally not be considered fixes. > Bug means potentially user visible fault. =A0In any bug fix commit you > should document the fault and its effects on users so those backporting > can decide if they care or not. Markus' changelogs leave much to be desired. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay0093.hostedemail.com ([216.40.44.93]:47329 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964882AbdJQWng (ORCPT ); Tue, 17 Oct 2017 18:43:36 -0400 Message-ID: <1508280210.6530.32.camel@perches.com> Subject: Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations From: Joe Perches To: James Bottomley , SF Markus Elfring , Dan Carpenter , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Jarkko Sakkinen , Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , Peter =?ISO-8859-1?Q?H=FCwe?= , Stefan Berger , LKML , kernel-janitors@vger.kernel.org Date: Tue, 17 Oct 2017 15:43:30 -0700 In-Reply-To: <1508255833.3129.33.camel@HansenPartnership.com> References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <20171016183139.otyh3m5c5yurtmow@linux.intel.com> <20171016183512.3bz6x4b6lbhpbkje@linux.intel.com> <20171017085124.pkrjzghcf5wmcydc@mwanda> <1508255833.3129.33.camel@HansenPartnership.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-integrity-owner@vger.kernel.org List-ID: On Tue, 2017-10-17 at 08:57 -0700, James Bottomley wrote: > On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote: > > > > > > Fixes is only for bug fixes. These don't fix any bugs. > > > > How do you distinguish these in questionable source code > > from other error categories or software weaknesses? > > A style change is one that doesn't change the effect of the execution. > These don't actually even change the assembly, so there's programmatic > proof they're not fixing anything. The printk removals do change the objects. The value of that type of change is only for resource limited systems. printk type changes should generally not be considered fixes. > Bug means potentially user visible fault. In any bug fix commit you > should document the fault and its effects on users so those backporting > can decide if they care or not. Markus' changelogs leave much to be desired. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yGqwq1QBFzDrFp for ; Wed, 18 Oct 2017 09:43:39 +1100 (AEDT) Message-ID: <1508280210.6530.32.camel@perches.com> Subject: Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations From: Joe Perches To: James Bottomley , SF Markus Elfring , Dan Carpenter , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Jarkko Sakkinen , Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , Peter =?ISO-8859-1?Q?H=FCwe?= , Stefan Berger , LKML , kernel-janitors@vger.kernel.org Date: Tue, 17 Oct 2017 15:43:30 -0700 In-Reply-To: <1508255833.3129.33.camel@HansenPartnership.com> References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <20171016183139.otyh3m5c5yurtmow@linux.intel.com> <20171016183512.3bz6x4b6lbhpbkje@linux.intel.com> <20171017085124.pkrjzghcf5wmcydc@mwanda> <1508255833.3129.33.camel@HansenPartnership.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2017-10-17 at 08:57 -0700, James Bottomley wrote: > On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote: > > > > > > Fixes is only for bug fixes.  These don't fix any bugs. > > > > How do you distinguish these in questionable source code > > from other error categories or software weaknesses? > > A style change is one that doesn't change the effect of the execution. >  These don't actually even change the assembly, so there's programmatic > proof they're not fixing anything. The printk removals do change the objects. The value of that type of change is only for resource limited systems. printk type changes should generally not be considered fixes. > Bug means potentially user visible fault.  In any bug fix commit you > should document the fault and its effects on users so those backporting > can decide if they care or not. Markus' changelogs leave much to be desired.