From: Joe Perches <joe@perches.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: scripts/checkpatch: Concatenated strings should use spaces between elements
Date: Tue, 17 Oct 2017 16:18:51 -0700 [thread overview]
Message-ID: <1508282331.6530.34.camel@perches.com> (raw)
In-Reply-To: <b96a64ab-326e-3b7e-21df-3a3487f02342@gmx.de>
On Wed, 2017-10-18 at 00:58 +0200, Heinrich Schuchardt wrote:
> On 10/18/2017 12:43 AM, Joe Perches wrote:
> > On Tue, 2017-10-17 at 23:17 +0200, Heinrich Schuchardt wrote:
> > > This patch creates a warning (CHECK)
> > > "Concatenated strings should use spaces between elements"
> > >
> > > There are no concatenated strings here.
> >
> > Yes, there are.
> >
> > > (checkpatch is also used in the U-Boot project where wide strings
> > > occur in the EFI implementation.)
> > >
> > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > > ---
> > > test.c | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > > create mode 100644 test.c
> > >
> > > diff --git a/test.c b/test.c
> > > new file mode 100644
> > > index 0000000000..dfd33cd765
> > > --- /dev/null
> > > +++ b/test.c
> > > @@ -0,0 +1,6 @@
> > > +#include <foo.h>
> > > +
> > > +void foo(void)
> > > +{
> > > + test(L"\"");
> >
> > In this case, L must be a constant string and you
> > are concatenating L and "\""
> >
> >
>
> See ISO/IEC 9899:1999
>
> 6.4.5 String literals
>
> <cite>
> A character string literal is a sequence of zero or more multibyte
> characters enclosed in double-quotes, as in "xyz"
> A wide string literal is the same, except prefixed by the
> letter L.
> </cite>
Kernel doesn't support wide strings.
> L"foo" is a literal of type wchar_t * and not two strings.
> L is a qualifier and not a constant string.
>
> Just like ULL in 10ULL.
>
> Regards
>
> Heinrich
next prev parent reply other threads:[~2017-10-17 23:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 21:17 scripts/checkpatch: Concatenated strings should use spaces between elements Heinrich Schuchardt
2017-10-17 22:43 ` Joe Perches
2017-10-17 22:58 ` Heinrich Schuchardt
2017-10-17 23:18 ` Joe Perches [this message]
2017-10-18 0:35 ` Joe Perches
2017-10-18 6:32 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508282331.6530.34.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.