From: Bastien Nocera <hadess@hadess.net>
To: Szymon Janc <szymon.janc@codecoup.pl>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 3/9] sixaxis: Ask user whether cable configuration should be allowed
Date: Wed, 18 Oct 2017 03:51:17 +0200 [thread overview]
Message-ID: <1508291477.5910.75.camel@hadess.net> (raw)
In-Reply-To: <1757680.YUP8J5zydk@ix>
On Wed, 2017-09-27 at 11:12 +0200, Szymon Janc wrote:
> Hi Bastien,
>
> On Monday, 4 September 2017 20:12:06 CEST Bastien Nocera wrote:
> > <snip>
> > + char device_addr[18];
>
> If this is needed only for debug then just convert address to string
> in place
> where it is printed.
The string was in string format already when we get it from the device,
but I've switched that to pass around a bdaddr_t instead.
<snip>
> > + closure = g_try_new0(struct authentication_closure, 1);
>
> Just use new0() instead.
Fixed.
I've also added a btd_device_set_trusted() as well, which was bizarrely
missing from this patch. I guess it got lost when I started splitting
up the original patches.
next prev parent reply other threads:[~2017-10-18 1:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 18:12 [PATCH 1/9] plugins/sixaxis: Remove LEDs handling Bastien Nocera
2017-09-04 18:12 ` [PATCH 2/9] adapter: Add btd_request_authorization_cable_configured() Bastien Nocera
2017-09-04 18:12 ` [PATCH 3/9] sixaxis: Ask user whether cable configuration should be allowed Bastien Nocera
2017-09-27 9:12 ` Szymon Janc
2017-10-18 1:51 ` Bastien Nocera [this message]
2017-09-27 9:14 ` Szymon Janc
2017-10-04 12:38 ` Bastien Nocera
2017-09-04 18:12 ` [PATCH 4/9] plugins/sixaxis: Move device discovery to shared header Bastien Nocera
2017-09-05 9:03 ` Bastien Nocera
2017-09-05 9:13 ` Szymon Janc
2017-09-05 10:37 ` Bastien Nocera
2017-09-04 18:12 ` [PATCH 5/9] profiles/input: Use sixaxis header to simplify device detection Bastien Nocera
2017-09-04 18:12 ` [PATCH 6/9] profiles/input: Add DS4 devices to the shared header Bastien Nocera
2017-09-04 18:12 ` [PATCH 7/9] plugins/sixaxis: Rename sixaxis specific functions Bastien Nocera
2017-09-04 18:12 ` [PATCH 8/9] plugins/sixaxis: Add support for DualShock 4/PS4 cable pairing Bastien Nocera
2017-09-27 9:12 ` Szymon Janc
2017-10-04 12:40 ` Bastien Nocera
2017-10-18 1:51 ` Bastien Nocera
2017-09-04 18:12 ` [PATCH 9/9] plugins/sixaxis: Cancel cable pairing if unplugged Bastien Nocera
2017-09-27 9:07 ` [PATCH 1/9] plugins/sixaxis: Remove LEDs handling Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508291477.5910.75.camel@hadess.net \
--to=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@codecoup.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.