All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 9/9] disas: Add capstone as submodule
Date: Wed, 18 Oct 2017 07:48:22 +0200	[thread overview]
Message-ID: <1508305702.10073.2.camel@redhat.com> (raw)
In-Reply-To: <20171017153742.10026-10-richard.henderson@linaro.org>

  Hi,

> +if [ "$capstone_internal" = "yes" ]; then
> +  echo "config-host.h: subdir-capstone" >> $config_host_mak
> +fi

I think this isn't going to work correctly.  In case both capstone and
dtc are used we need a single line with the dependencies, i.e.

  config-host.h: subdir-dtc subdir-capstone

cheers,
  Gerd

  reply	other threads:[~2017-10-18  5:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17 15:37 [Qemu-devel] [PATCH v5 0/9] Support the Capstone disassembler Richard Henderson
2017-10-17 15:37 ` [Qemu-devel] [PATCH v5 1/9] target/i386: Convert to disas_set_info hook Richard Henderson
2017-10-17 15:37 ` [Qemu-devel] [PATCH v5 2/9] target/ppc: " Richard Henderson
2017-10-17 15:37 ` [Qemu-devel] [PATCH v5 3/9] disas: Remove unused flags arguments Richard Henderson
2017-10-17 15:37 ` [Qemu-devel] [PATCH v5 4/9] disas: Support the Capstone disassembler library Richard Henderson
2017-10-18 21:48   ` Philippe Mathieu-Daudé
2017-10-17 15:37 ` [Qemu-devel] [PATCH v5 5/9] i386: Support Capstone in disas_set_info Richard Henderson
2017-10-17 15:37 ` [Qemu-devel] [PATCH v5 6/9] arm: " Richard Henderson
2017-10-17 15:37 ` [Qemu-devel] [PATCH v5 7/9] ppc: " Richard Henderson
2017-10-17 15:37 ` [Qemu-devel] [PATCH v5 8/9] disas: Remove monitor_disas_is_physical Richard Henderson
2017-10-17 15:37 ` [Qemu-devel] [PATCH v5 9/9] disas: Add capstone as submodule Richard Henderson
2017-10-18  5:48   ` Gerd Hoffmann [this message]
2017-10-18 13:26     ` Richard Henderson
2017-10-18 13:29     ` Eric Blake
2017-10-18 13:34   ` Daniel P. Berrange
2017-10-18 14:14     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508305702.10073.2.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.