From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v7 2/4] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter
Date: Wed, 18 Oct 2017 13:58:05 +0300 [thread overview]
Message-ID: <1508324285.4517.1.camel@linux.intel.com> (raw)
In-Reply-To: <1508280649-26705-3-git-send-email-sujaritha.sundaresan@intel.com>
On Tue, 2017-10-17 at 15:50 -0700, Sujaritha Sundaresan wrote:
> We currently have two module parameters that control GuC:
> "enable_guc_loading" and "enable_guc_submission". Whenever
> we need i915_modparams.enable_guc_submission=1, we also need
> enable_guc_loading=1. We also need enable_guc_loading=1 when
> we want to verify the HuC, which is every time we have a HuC
> (but all platforms with HuC have a GuC and viceversa).
I already gave comments about clarifying the commit message, that does
not seem to have been addressed.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-18 10:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 22:50 [PATCH v7 0/4] drm/i915/guc : Removing enable_guc_loading module and Decoupling logs and ADS from submission Sujaritha Sundaresan
2017-10-17 22:50 ` [PATCH v7 1/4] drm/i915 : Unifying seq_puts messages for feature support Sujaritha Sundaresan
2017-10-18 6:49 ` Michal Wajdeczko
2017-10-17 22:50 ` [PATCH v7 2/4] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter Sujaritha Sundaresan
2017-10-17 22:57 ` Chris Wilson
2017-10-23 16:56 ` Sujaritha
2017-10-18 10:58 ` Joonas Lahtinen [this message]
2017-10-18 16:25 ` Sujaritha
2017-10-18 16:50 ` Joonas Lahtinen
2017-10-18 16:50 ` Sujaritha
2017-10-18 11:53 ` Michal Wajdeczko
2017-10-23 17:41 ` Sujaritha
2017-10-24 16:00 ` Sujaritha
2017-10-17 22:50 ` [PATCH v7 3/4] drm/i915/guc : Updating GuC and HuC FW select function Sujaritha Sundaresan
2017-10-18 10:29 ` Sagar Arun Kamble
2017-10-18 21:17 ` Michal Wajdeczko
2017-10-23 21:08 ` Sujaritha
2017-10-23 21:07 ` Sujaritha
2017-10-17 22:50 ` [PATCH v7 4/4] drm/i915/guc : Decouple logs and ADS from submission Sujaritha Sundaresan
2017-10-18 21:45 ` Michal Wajdeczko
2017-10-17 22:59 ` ✗ Fi.CI.BAT: failure for drm/i915/guc : Removing enable_guc_loading module and Decoupling logs and ADS from submission (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2017-10-17 22:49 [PATCH v7 0/4] drm/i915/guc : Removing enable_guc_loading module Sujaritha Sundaresan
2017-10-17 22:49 ` [PATCH v7 2/4] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter Sujaritha Sundaresan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508324285.4517.1.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sujaritha.sundaresan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.