From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: Patch "EDAC, mce_amd: Print IPID and Syndrome on a separate line" has been added to the 4.9-stable tree From: Greg Kroah-Hartman Message-Id: <150841885112573@kroah.com> Date: Thu, 19 Oct 2017 15:14:11 +0200 To: Yazen.Ghannam@amd.com, alexander.levin@verizon.com, bp@suse.de, gregkh@linuxfoundation.org, linux-edac@vger.kernel.org Cc: stable@vger.kernel.org, stable-commits@vger.kernel.org List-ID: VGhpcyBpcyBhIG5vdGUgdG8gbGV0IHlvdSBrbm93IHRoYXQgSSd2ZSBqdXN0IGFkZGVkIHRoZSBw YXRjaCB0aXRsZWQKCiAgICBFREFDLCBtY2VfYW1kOiBQcmludCBJUElEIGFuZCBTeW5kcm9tZSBv biBhIHNlcGFyYXRlIGxpbmUKCnRvIHRoZSA0Ljktc3RhYmxlIHRyZWUgd2hpY2ggY2FuIGJlIGZv dW5kIGF0OgogICAgaHR0cDovL3d3dy5rZXJuZWwub3JnL2dpdC8/cD1saW51eC9rZXJuZWwvZ2l0 L3N0YWJsZS9zdGFibGUtcXVldWUuZ2l0O2E9c3VtbWFyeQoKVGhlIGZpbGVuYW1lIG9mIHRoZSBw YXRjaCBpczoKICAgICBlZGFjLW1jZV9hbWQtcHJpbnQtaXBpZC1hbmQtc3luZHJvbWUtb24tYS1z ZXBhcmF0ZS1saW5lLnBhdGNoCmFuZCBpdCBjYW4gYmUgZm91bmQgaW4gdGhlIHF1ZXVlLTQuOSBz dWJkaXJlY3RvcnkuCgpJZiB5b3UsIG9yIGFueW9uZSBlbHNlLCBmZWVscyBpdCBzaG91bGQgbm90 IGJlIGFkZGVkIHRvIHRoZSBzdGFibGUgdHJlZSwKcGxlYXNlIGxldCA8c3RhYmxlQHZnZXIua2Vy bmVsLm9yZz4ga25vdyBhYm91dCBpdC4KCgpGcm9tIGZvb0BiYXogVGh1IE9jdCAxOSAxNTowNDow MiBDRVNUIDIwMTcKRnJvbTogWWF6ZW4gR2hhbm5hbSA8WWF6ZW4uR2hhbm5hbUBhbWQuY29tPgpE YXRlOiBXZWQsIDE1IEZlYiAyMDE3IDE0OjU2OjIyIC0wNjAwClN1YmplY3Q6IEVEQUMsIG1jZV9h bWQ6IFByaW50IElQSUQgYW5kIFN5bmRyb21lIG9uIGEgc2VwYXJhdGUgbGluZQoKRnJvbTogWWF6 ZW4gR2hhbm5hbSA8WWF6ZW4uR2hhbm5hbUBhbWQuY29tPgoKClsgVXBzdHJlYW0gY29tbWl0IDc1 YmYyZjY0NzhjYWI5YjBjMWQ3ZjVmNjc0YTc2NWQxZTJhZDUzMGUgXQoKQ3VycmVudGx5LCB0aGUg SVBJRCBhbmQgU3luZHJvbWUgYXJlIHByaW50ZWQgb24gdGhlIHNhbWUgbGluZSBhcyB0aGUKQWRk cmVzcy4gVGhlcmUgYXJlIGNhc2VzIHdoZW4gd2UgY2FuIGhhdmUgYSB2YWxpZCBTeW5kcm9tZSBi dXQgbm90IGEKdmFsaWQgQWRkcmVzcy4KCkZvciBleGFtcGxlLCB0aGUgTUNBX1NZTkQgcmVnaXN0 ZXIgY2FuIGJlIHVzZWQgdG8gaG9sZCBtb3JlIGRldGFpbGVkCmVycm9yIGluZm8gdGhhdCB0aGUg aGFyZHdhcmUgZm9sa3MgY2FuIHVzZS4gSXQncyBub3QganVzdCBEUkFNIEVDQwpzeW5kcm9tZXMu IFRoZXJlIGFyZSBzb21lIGVycm9yIHR5cGVzIHRoYXQgYXJlbid0IHJlbGF0ZWQgdG8gbWVtb3J5 IHRoYXQKbWF5IGhhdmUgdmFsaWQgc3luZHJvbWVzLCBsaWtlIHNvbWUgZXJyb3JzIHJlbGF0ZWQg dG8gbGlua3MgaW4gdGhlIERhdGEKRmFicmljLCBldGMuCgpJbiB0aGVzZSBjYXNlcywgdGhlIElQ SUQgYW5kIFN5bmRyb21lIGFyZSBub3QgcHJpbnRlZCBhdCB0aGUgc2FtZSBsb2cKbGV2ZWwgYXMg dGhlIHJlc3Qgb2YgdGhlIHN0YW56YSwgc28gdXNlcnMgd29uJ3Qgc2VlIHRoZW0gb24gdGhlIGNv bnNvbGUuCgpDb25zb2xlOgogIFtIYXJkd2FyZSBFcnJvcl06IENQVToxNiAoMTc6MTowKSBNQzIy X1NUQVRVU1tPdmVyfENFfE1pc2NWfC18LXwtfC18U3luZFZ8LV06IDB4ZDgyMDAwMDAwMDAyMDgw YgogIFtIYXJkd2FyZSBFcnJvcl06IFBvd2VyLCBJbnRlcnJ1cHRzLCBldGMuIEV4dGVuZGVkIEVy cm9yIENvZGU6IDIKCkRtZXNnOgogIFtIYXJkd2FyZSBFcnJvcl06IENQVToxNiAoMTc6MTowKSBN QzIyX1NUQVRVU1tPdmVyfENFfE1pc2NWfC18LXwtfC18U3luZFZ8LV06IDB4ZDgyMDAwMDAwMDAy MDgwYgogICwgU3luZHJvbWU6IDB4MDAwMDAwMDEwYjQwNDAwMCwgSVBJRDogMHgwMDAxMDAyZTAw MDAwMDAyCiAgW0hhcmR3YXJlIEVycm9yXTogUG93ZXIsIEludGVycnVwdHMsIGV0Yy4gRXh0ZW5k ZWQgRXJyb3IgQ29kZTogMgoKUHJpbnQgdGhlIElQSUQgZmlyc3QgYW5kIG9uIGEgbmV3IGxpbmUu IFRoZSBJUElEIHNob3VsZCBhbHdheXMgYmUKcHJpbnRlZCBvbiBTTUNBIHN5c3RlbXMuIFRoZSBT eW5kcm9tZSB3aWxsIHRoZW4gYmUgcHJpbnRlZCB3aXRoIHRoZSBJUElECmFuZCBhdCB0aGUgc2Ft ZSBsb2cgbGV2ZWwgd2hlbiB2YWxpZDoKCiAgW0hhcmR3YXJlIEVycm9yXTogQ1BVOjE2ICgxNzox OjApIE1DMjJfU1RBVFVTW092ZXJ8Q0V8TWlzY1Z8LXwtfC18LXxTeW5kVnwtXTogMHhkODIwMDAw MDAwMDIwODBiCiAgW0hhcmR3YXJlIEVycm9yXTogSVBJRDogMHgwMDAxMDAyZTAwMDAwMDAyLCBT eW5kcm9tZTogMHgwMDAwMDAwMTBiNDA0MDAwCiAgW0hhcmR3YXJlIEVycm9yXTogUG93ZXIsIElu dGVycnVwdHMsIGV0Yy4gRXh0ZW5kZWQgRXJyb3IgQ29kZTogMgoKU2lnbmVkLW9mZi1ieTogWWF6 ZW4gR2hhbm5hbSA8WWF6ZW4uR2hhbm5hbUBhbWQuY29tPgpDYzogbGludXgtZWRhYyA8bGludXgt ZWRhY0B2Z2VyLmtlcm5lbC5vcmc+Ckxpbms6IGh0dHA6Ly9sa21sLmtlcm5lbC5vcmcvci8xNDg3 MTkyMTgyLTI0NzQtMS1naXQtc2VuZC1lbWFpbC1ZYXplbi5HaGFubmFtQGFtZC5jb20KU2lnbmVk LW9mZi1ieTogQm9yaXNsYXYgUGV0a292IDxicEBzdXNlLmRlPgpTaWduZWQtb2ZmLWJ5OiBTYXNo YSBMZXZpbiA8YWxleGFuZGVyLmxldmluQHZlcml6b24uY29tPgpTaWduZWQtb2ZmLWJ5OiBHcmVn IEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPgotLS0KIGRyaXZlcnMv ZWRhYy9tY2VfYW1kLmMgfCAgICA5ICsrKystLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0 aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCgoKUGF0Y2hlcyBjdXJyZW50bHkgaW4gc3RhYmxlLXF1 ZXVlIHdoaWNoIG1pZ2h0IGJlIGZyb20gWWF6ZW4uR2hhbm5hbUBhbWQuY29tIGFyZQoKcXVldWUt NC45L2VkYWMtbWNlX2FtZC1wcmludC1pcGlkLWFuZC1zeW5kcm9tZS1vbi1hLXNlcGFyYXRlLWxp bmUucGF0Y2gKLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUg InVuc3Vic2NyaWJlIGxpbnV4LWVkYWMiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpv cmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2Vy Lmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAoKLS0tIGEvZHJpdmVycy9lZGFjL21jZV9h bWQuYworKysgYi9kcml2ZXJzL2VkYWMvbWNlX2FtZC5jCkBAIC05ODEsMjAgKzk4MSwxOSBAQCBp bnQgYW1kX2RlY29kZV9tY2Uoc3RydWN0IG5vdGlmaWVyX2Jsb2NrCiAJcHJfY29udCgiXTogMHgl MDE2bGx4XG4iLCBtLT5zdGF0dXMpOwogCiAJaWYgKG0tPnN0YXR1cyAmIE1DSV9TVEFUVVNfQURE UlYpCi0JCXByX2VtZXJnKEhXX0VSUiAiRXJyb3IgQWRkcjogMHglMDE2bGx4IiwgbS0+YWRkcik7 CisJCXByX2VtZXJnKEhXX0VSUiAiRXJyb3IgQWRkcjogMHglMDE2bGx4XG4iLCBtLT5hZGRyKTsK IAogCWlmIChib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfU01DQSkpIHsKKwkJcHJfZW1lcmcoSFdf RVJSICJJUElEOiAweCUwMTZsbHgiLCBtLT5pcGlkKTsKKwogCQlpZiAobS0+c3RhdHVzICYgTUNJ X1NUQVRVU19TWU5EVikKIAkJCXByX2NvbnQoIiwgU3luZHJvbWU6IDB4JTAxNmxseCIsIG0tPnN5 bmQpOwogCi0JCXByX2NvbnQoIiwgSVBJRDogMHglMDE2bGx4IiwgbS0+aXBpZCk7Ci0KIAkJcHJf Y29udCgiXG4iKTsKIAogCQlkZWNvZGVfc21jYV9lcnJvcnMobSk7CiAJCWdvdG8gZXJyX2NvZGU7 Ci0JfSBlbHNlCi0JCXByX2NvbnQoIlxuIik7CisJfQogCiAJaWYgKCFmYW1fb3BzKQogCQlnb3Rv IGVycl9jb2RlOwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:42134 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752576AbdJSNOT (ORCPT ); Thu, 19 Oct 2017 09:14:19 -0400 Subject: Patch "EDAC, mce_amd: Print IPID and Syndrome on a separate line" has been added to the 4.9-stable tree To: Yazen.Ghannam@amd.com, alexander.levin@verizon.com, bp@suse.de, gregkh@linuxfoundation.org, linux-edac@vger.kernel.org Cc: , From: Date: Thu, 19 Oct 2017 15:14:11 +0200 Message-ID: <150841885112573@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled EDAC, mce_amd: Print IPID and Syndrome on a separate line to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: edac-mce_amd-print-ipid-and-syndrome-on-a-separate-line.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From foo@baz Thu Oct 19 15:04:02 CEST 2017 From: Yazen Ghannam Date: Wed, 15 Feb 2017 14:56:22 -0600 Subject: EDAC, mce_amd: Print IPID and Syndrome on a separate line From: Yazen Ghannam [ Upstream commit 75bf2f6478cab9b0c1d7f5f674a765d1e2ad530e ] Currently, the IPID and Syndrome are printed on the same line as the Address. There are cases when we can have a valid Syndrome but not a valid Address. For example, the MCA_SYND register can be used to hold more detailed error info that the hardware folks can use. It's not just DRAM ECC syndromes. There are some error types that aren't related to memory that may have valid syndromes, like some errors related to links in the Data Fabric, etc. In these cases, the IPID and Syndrome are not printed at the same log level as the rest of the stanza, so users won't see them on the console. Console: [Hardware Error]: CPU:16 (17:1:0) MC22_STATUS[Over|CE|MiscV|-|-|-|-|SyndV|-]: 0xd82000000002080b [Hardware Error]: Power, Interrupts, etc. Extended Error Code: 2 Dmesg: [Hardware Error]: CPU:16 (17:1:0) MC22_STATUS[Over|CE|MiscV|-|-|-|-|SyndV|-]: 0xd82000000002080b , Syndrome: 0x000000010b404000, IPID: 0x0001002e00000002 [Hardware Error]: Power, Interrupts, etc. Extended Error Code: 2 Print the IPID first and on a new line. The IPID should always be printed on SMCA systems. The Syndrome will then be printed with the IPID and at the same log level when valid: [Hardware Error]: CPU:16 (17:1:0) MC22_STATUS[Over|CE|MiscV|-|-|-|-|SyndV|-]: 0xd82000000002080b [Hardware Error]: IPID: 0x0001002e00000002, Syndrome: 0x000000010b404000 [Hardware Error]: Power, Interrupts, etc. Extended Error Code: 2 Signed-off-by: Yazen Ghannam Cc: linux-edac Link: http://lkml.kernel.org/r/1487192182-2474-1-git-send-email-Yazen.Ghannam@amd.com Signed-off-by: Borislav Petkov Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/edac/mce_amd.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) --- a/drivers/edac/mce_amd.c +++ b/drivers/edac/mce_amd.c @@ -981,20 +981,19 @@ int amd_decode_mce(struct notifier_block pr_cont("]: 0x%016llx\n", m->status); if (m->status & MCI_STATUS_ADDRV) - pr_emerg(HW_ERR "Error Addr: 0x%016llx", m->addr); + pr_emerg(HW_ERR "Error Addr: 0x%016llx\n", m->addr); if (boot_cpu_has(X86_FEATURE_SMCA)) { + pr_emerg(HW_ERR "IPID: 0x%016llx", m->ipid); + if (m->status & MCI_STATUS_SYNDV) pr_cont(", Syndrome: 0x%016llx", m->synd); - pr_cont(", IPID: 0x%016llx", m->ipid); - pr_cont("\n"); decode_smca_errors(m); goto err_code; - } else - pr_cont("\n"); + } if (!fam_ops) goto err_code; Patches currently in stable-queue which might be from Yazen.Ghannam@amd.com are queue-4.9/edac-mce_amd-print-ipid-and-syndrome-on-a-separate-line.patch