From: David Howells <dhowells@redhat.com>
To: Jann Horn <jannh@google.com>
Cc: dhowells@redhat.com, Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] tls: fix NULL deref on tls_sw_splice_eof() with empty record
Date: Mon, 27 Nov 2023 09:04:13 +0000 [thread overview]
Message-ID: <1508421.1701075853@warthog.procyon.org.uk> (raw)
In-Reply-To: <20231122214447.675768-1-jannh@google.com>
Jann Horn <jannh@google.com> wrote:
> + /* same checks as in tls_sw_push_pending_record() */
Wouldn't it be better to say what you're checking rather than referring off to
another function that might one day disappear or be renamed?
David
next prev parent reply other threads:[~2023-11-27 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 21:44 [PATCH net] tls: fix NULL deref on tls_sw_splice_eof() with empty record Jann Horn
2023-11-22 21:58 ` Jann Horn
2023-11-26 23:56 ` John Fastabend
2023-11-23 17:00 ` patchwork-bot+netdevbpf
2023-11-27 9:04 ` David Howells [this message]
2023-11-27 13:10 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508421.1701075853@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=jannh@google.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.