From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "willy@infradead.org" <willy@infradead.org>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@kernel.org" <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"byungchul.park@lge.com" <byungchul.park@lge.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"kernel-team@lge.com" <kernel-team@lge.com>
Subject: Re: [PATCH v2 2/3] lockdep: Remove BROKEN flag of LOCKDEP_CROSSRELEASE
Date: Thu, 19 Oct 2017 20:41:23 +0000 [thread overview]
Message-ID: <1508445681.2429.61.camel@wdc.com> (raw)
In-Reply-To: <20171019203313.GA10538@bombadil.infradead.org>
On Thu, 2017-10-19 at 13:33 -0700, Matthew Wilcox wrote:
> For example, the page lock is not annotatable with lockdep -- we return
> to userspace with it held, for heaven's sake! So it is quite easy for
> someone not familiar with the MM locking hierarchy to inadvertently
> introduce an ABBA deadlock against the page lock. (ie me. I did that.)
> Right now, that has to be caught by a human reviewer; if cross-release
> checking can catch that, then it's worth having.
Hello Matthew,
Although I agree that enabling lock inversion checking for page locks is
useful, I think my questions still apply to other locking objects than page
locks.
Thanks,
Bart.
next prev parent reply other threads:[~2017-10-19 20:41 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 5:55 [PATCH v2 0/3] crossrelease: make it not unwind by default Byungchul Park
2017-10-19 5:55 ` Byungchul Park
2017-10-19 5:55 ` [PATCH v2 1/3] lockdep: Introduce CROSSRELEASE_STACK_TRACE and make it not unwind as default Byungchul Park
2017-10-19 5:55 ` Byungchul Park
2017-10-19 5:55 ` [PATCH v2 2/3] lockdep: Remove BROKEN flag of LOCKDEP_CROSSRELEASE Byungchul Park
2017-10-19 5:55 ` Byungchul Park
2017-10-19 15:05 ` Bart Van Assche
2017-10-19 15:05 ` Bart Van Assche
2017-10-19 15:34 ` Thomas Gleixner
2017-10-19 15:34 ` Thomas Gleixner
2017-10-19 15:47 ` Bart Van Assche
2017-10-19 19:04 ` Thomas Gleixner
2017-10-19 19:04 ` Thomas Gleixner
2017-10-19 19:12 ` Thomas Gleixner
2017-10-19 19:12 ` Thomas Gleixner
2017-10-19 20:21 ` Bart Van Assche
2017-10-19 20:21 ` Bart Van Assche
2017-10-19 20:33 ` Matthew Wilcox
2017-10-19 20:33 ` Matthew Wilcox
2017-10-19 20:41 ` Bart Van Assche [this message]
2017-10-19 20:53 ` Thomas Gleixner
2017-10-19 20:53 ` Thomas Gleixner
2017-10-19 20:49 ` Thomas Gleixner
2017-10-19 20:49 ` Thomas Gleixner
2017-10-20 7:30 ` Ingo Molnar
2017-10-20 7:30 ` Ingo Molnar
2017-10-20 6:03 ` Byungchul Park
2017-10-20 6:03 ` Byungchul Park
2017-10-19 5:55 ` [PATCH v2 3/3] lockdep: Add a kernel parameter, crossrelease_fullstack Byungchul Park
2017-10-19 5:55 ` Byungchul Park
2017-10-19 7:03 ` [PATCH v2 0/4] Fix false positives by cross-release feature Byungchul Park
2017-10-19 7:03 ` Byungchul Park
2017-10-19 7:03 ` [PATCH v2 1/4] completion: Add support for initializing completion with lockdep_map Byungchul Park
2017-10-19 7:03 ` Byungchul Park
2017-10-19 7:03 ` [PATCH v2 2/4] lockdep: Remove unnecessary acquisitions wrt workqueue flush Byungchul Park
2017-10-19 7:03 ` Byungchul Park
2017-10-19 7:03 ` [PATCH v2 3/4] genhd.h: Remove trailing white space Byungchul Park
2017-10-19 7:03 ` Byungchul Park
2017-10-19 7:03 ` [PATCH v2 4/4] lockdep: Assign a lock_class per gendisk used for wait_for_completion() Byungchul Park
2017-10-19 7:03 ` Byungchul Park
2017-10-20 14:44 ` Christoph Hellwig
2017-10-20 14:44 ` Christoph Hellwig
2017-10-20 14:44 ` Christoph Hellwig
2017-10-22 23:53 ` Byungchul Park
2017-10-22 23:53 ` Byungchul Park
2017-10-23 6:36 ` Christoph Hellwig
2017-10-23 6:36 ` Christoph Hellwig
2017-10-23 7:04 ` Byungchul Park
2017-10-23 7:04 ` Byungchul Park
2017-10-21 19:17 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508445681.2429.61.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=byungchul.park@lge.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.