From: Arnd Bergmann <arnd@arndb.de>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Bryan Wu <cooloney@gmail.com>, Lee Jones <lee.jones@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Aaron Lu <aaron.lu@intel.com>
Subject: Re: [PATCH v3 10/15] leds: leds-gpio: Add ACPI probing support
Date: Wed, 01 Oct 2014 20:22:36 +0200 [thread overview]
Message-ID: <15084898.uePkciO2J1@wuerfel> (raw)
In-Reply-To: <D05191AB.AB380%dvhart@linux.intel.com>
On Wednesday 01 October 2014 11:11:46 Darren Hart wrote:
> >
> >No, I think in absence of drv->acpi_match_table ACPI core should just go
> >and
> >use drv->of_match_table to do the matching and be done with it.
>
> But then you will match drivers that have of-only support that don't know
> anything about ACPI and haven't been updated to use the new API. Worse,
> some of those drivers will assume of node structs and such and potentially
> panic. Unless I'm sorry mistaken here....
>
I don't think that is a huge danger: most drivers tend to check for
the presence of dev->of_node before calling any of the DT interfaces,
you'd only ever enter the probe function if the compatible string matches
(i.e. an old kernel with a new ACPI table), and most users of ACPI
systems will disable CONFIG_OF at compile time, so the accessors looking
at the of_node are not there.
In theory it's possible that something goes wrong here, but it's not
very likely to ever cause problems.
Arnd
next prev parent reply other threads:[~2014-10-01 18:22 UTC|newest]
Thread overview: 152+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 11:52 [RFC PATCH v2 00/16] Add ACPI _DSD and unified device properties support Mika Westerberg
2014-09-16 11:52 ` Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 01/16] ACPI: Add support for device specific properties Mika Westerberg
2014-10-06 13:50 ` Grant Likely
2014-10-06 13:50 ` Grant Likely
[not found] ` <20141006135021.0EB04C43FBE-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-10-06 14:32 ` Mika Westerberg
2014-10-06 14:32 ` Mika Westerberg
2014-10-06 16:25 ` Darren Hart
2014-10-06 16:25 ` Darren Hart
2014-09-16 11:52 ` [RFC PATCH v2 02/16] Driver core: Unified device properties interface for platform firmware Mika Westerberg
2014-09-17 18:28 ` Greg Kroah-Hartman
2014-09-16 11:52 ` [RFC PATCH v2 03/16] ACPI: Allow drivers to match using Device Tree compatible property Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 04/16] ACPI: Document ACPI device specific properties Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 05/16] mfd: Add ACPI support Mika Westerberg
2014-09-16 21:54 ` Lee Jones
2014-09-16 21:54 ` Lee Jones
2014-09-24 12:00 ` Lee Jones
2014-09-24 12:00 ` Lee Jones
2014-09-16 11:52 ` [RFC PATCH v2 06/16] gpio / ACPI: Add support for _DSD device properties Mika Westerberg
2014-09-23 15:27 ` Linus Walleij
2014-09-16 11:52 ` [RFC PATCH v2 07/16] gpio: Add support for unified device properties interface Mika Westerberg
[not found] ` <1410868367-11056-8-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-23 15:25 ` Linus Walleij
2014-09-23 15:25 ` Linus Walleij
2014-09-23 15:45 ` Arnd Bergmann
2014-09-23 15:52 ` Mika Westerberg
2014-09-23 15:52 ` Mika Westerberg
2014-09-23 16:17 ` Dmitry Torokhov
[not found] ` <20140923161724.GA40700-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2014-09-23 20:31 ` Rafael J. Wysocki
2014-09-23 20:31 ` Rafael J. Wysocki
2014-09-23 16:25 ` Rafael J. Wysocki
2014-09-23 16:25 ` Rafael J. Wysocki
[not found] ` <2895905.coa5UvrkJk-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-09-23 16:26 ` Arnd Bergmann
2014-09-23 16:26 ` Arnd Bergmann
2014-09-23 20:47 ` Rafael J. Wysocki
[not found] ` <1579761.oeYleOAY1N-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-09-24 7:55 ` Arnd Bergmann
2014-09-24 7:55 ` Arnd Bergmann
2014-09-24 14:08 ` Rafael J. Wysocki
2014-09-23 21:15 ` Darren Hart
2014-09-24 9:12 ` Arnd Bergmann
2014-09-24 9:38 ` Mika Westerberg
2014-09-24 14:11 ` Rafael J. Wysocki
2014-09-26 3:21 ` Darren Hart
2014-09-26 8:36 ` Arnd Bergmann
2014-09-26 14:42 ` Rafael J. Wysocki
2014-10-07 13:37 ` Linus Walleij
2014-10-07 15:37 ` Andy Shevchenko
2014-10-07 23:57 ` Rafael J. Wysocki
2014-09-16 11:52 ` [RFC PATCH v2 08/16] gpio: sch: Consolidate core and resume banks Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 09/16] leds: leds-gpio: Add support for GPIO descriptors Mika Westerberg
2014-09-19 8:18 ` Alexandre Courbot
2014-09-24 7:55 ` Linus Walleij
2014-09-24 9:42 ` Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 10/16] leds: leds-gpio: Make use of device property API Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 11/16] leds: leds-gpio: Add ACPI probing support Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 12/16] input: gpio_keys_polled - Add support for GPIO descriptors Mika Westerberg
2014-09-19 8:22 ` Alexandre Courbot
2014-09-24 8:02 ` Linus Walleij
2014-09-16 11:52 ` [RFC PATCH v2 13/16] input: gpio_keys_polled - Make use of device property API Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 14/16] input: gpio_keys_polled - Add ACPI probing support Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 15/16] misc: at25: Make use of device property API Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 16/16] misc: at25: Add ACPI probing support Mika Westerberg
2014-09-21 0:26 ` [RFC PATCH v2 00/16] Add ACPI _DSD and unified device properties support Rafael J. Wysocki
2014-09-24 8:34 ` Lee Jones
2014-09-24 9:45 ` Mika Westerberg
2014-09-22 23:29 ` Bryan Wu
2014-10-01 2:08 ` [PATCH v3 00/15] " Rafael J. Wysocki
2014-10-01 2:08 ` [PATCH v3 01/15] ACPI: Add support for device specific properties Rafael J. Wysocki
2014-10-01 7:38 ` Arnd Bergmann
2014-10-01 2:10 ` [PATCH v3 02/15] Driver core: Unified device properties interface for platform firmware Rafael J. Wysocki
2014-10-01 7:47 ` Arnd Bergmann
2014-10-01 22:09 ` Rafael J. Wysocki
2014-10-01 23:01 ` Rafael J. Wysocki
2014-10-02 7:46 ` Arnd Bergmann
2014-10-02 16:50 ` Rafael J. Wysocki
2014-10-02 0:03 ` Greg Kroah-Hartman
2014-10-01 2:10 ` [PATCH v3 03/15] ACPI: Allow drivers to match using Device Tree compatible property Rafael J. Wysocki
2014-10-01 7:48 ` Arnd Bergmann
2014-10-03 13:43 ` Mark Rutland
2014-10-03 17:59 ` Dmitry Torokhov
2014-10-04 0:02 ` Rafael J. Wysocki
2014-10-04 0:02 ` Rafael J. Wysocki
2014-10-01 2:11 ` [PATCH v3 04/15] ACPI: Document ACPI device specific properties Rafael J. Wysocki
2014-10-01 7:59 ` Arnd Bergmann
2014-10-02 10:41 ` Mika Westerberg
2014-10-02 11:51 ` Arnd Bergmann
2014-10-02 12:15 ` Mika Westerberg
2014-10-02 12:46 ` Arnd Bergmann
2014-10-02 13:36 ` Mika Westerberg
2014-10-02 14:29 ` Arnd Bergmann
2014-10-02 14:38 ` Mika Westerberg
2014-10-02 14:55 ` Arnd Bergmann
2014-10-03 13:56 ` Mark Rutland
2014-10-03 15:02 ` Arnd Bergmann
2014-10-03 23:58 ` Rafael J. Wysocki
2014-10-04 10:56 ` Arnd Bergmann
2014-10-05 21:40 ` Rafael J. Wysocki
2014-10-05 21:40 ` Rafael J. Wysocki
2014-10-03 2:03 ` Rafael J. Wysocki
2014-10-03 8:12 ` Mika Westerberg
2014-10-03 13:58 ` Mark Rutland
2014-10-03 14:38 ` Rafael J. Wysocki
2014-10-03 14:35 ` Mark Rutland
2014-10-04 0:13 ` Rafael J. Wysocki
[not found] ` <6568619.UkU5qISONv-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-10-04 10:59 ` Arnd Bergmann
2014-10-04 10:59 ` Arnd Bergmann
2014-10-05 22:26 ` Rafael J. Wysocki
2014-10-03 13:48 ` Mark Rutland
2014-10-04 0:16 ` Rafael J. Wysocki
2014-10-01 2:12 ` [PATCH v3 05/15] gpio / ACPI: Add support for _DSD device properties Rafael J. Wysocki
[not found] ` <4786851.38d7sjpzag-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-10-01 8:03 ` Arnd Bergmann
2014-10-01 8:03 ` Arnd Bergmann
2014-10-05 10:36 ` Alexandre Courbot
2014-10-05 21:20 ` Rafael J. Wysocki
[not found] ` <1852462.V1jlbi8OPt-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-10-01 2:14 ` [PATCH v3 06/15] gpio: Support for unified device properties interface Rafael J. Wysocki
2014-10-01 2:14 ` Rafael J. Wysocki
2014-10-01 2:22 ` [PATCH v3 15/15] misc: at25: Add ACPI probing support Rafael J. Wysocki
2014-10-01 2:22 ` Rafael J. Wysocki
2014-10-01 8:15 ` Arnd Bergmann
2014-10-01 2:15 ` [PATCH v3 07/15] gpio: sch: Consolidate core and resume banks Rafael J. Wysocki
2014-10-01 2:15 ` [PATCH v3 08/15] leds: leds-gpio: Add support for GPIO descriptors Rafael J. Wysocki
[not found] ` <1490183.QvrzPxsV7q-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-10-01 8:05 ` Arnd Bergmann
2014-10-01 8:05 ` Arnd Bergmann
2014-10-01 2:16 ` [PATCH v3 09/15] leds: leds-gpio: Make use of device property API Rafael J. Wysocki
2014-10-03 14:07 ` Mark Rutland
2014-10-04 0:18 ` Rafael J. Wysocki
2014-10-01 2:17 ` [PATCH v3 10/15] leds: leds-gpio: Add ACPI probing support Rafael J. Wysocki
2014-10-01 8:13 ` Arnd Bergmann
2014-10-01 9:13 ` Mika Westerberg
2014-10-01 10:01 ` Arnd Bergmann
2014-10-01 11:59 ` Mika Westerberg
2014-10-01 13:52 ` Arnd Bergmann
2014-10-01 14:04 ` Mika Westerberg
[not found] ` <20141001140441.GF1786-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-10-01 14:14 ` Arnd Bergmann
2014-10-01 14:14 ` Arnd Bergmann
2014-10-02 9:55 ` Mika Westerberg
2014-10-02 10:44 ` Arnd Bergmann
2014-10-01 16:30 ` Dmitry Torokhov
2014-10-01 18:11 ` Darren Hart
2014-10-01 18:11 ` Darren Hart
2014-10-01 18:21 ` Dmitry Torokhov
2014-10-01 18:22 ` Arnd Bergmann [this message]
2014-10-01 2:17 ` [PATCH v3 11/15] input: gpio_keys_polled - Add support for GPIO descriptors Rafael J. Wysocki
2014-10-01 8:13 ` Arnd Bergmann
2014-10-01 2:20 ` [PATCH v3 12/15] input: gpio_keys_polled - Make use of device property API Rafael J. Wysocki
2014-10-01 2:20 ` [PATCH v3 13/15] input: gpio_keys_polled - Add ACPI probing support Rafael J. Wysocki
2014-10-01 7:48 ` Dmitry Torokhov
2014-10-01 9:15 ` Mika Westerberg
2014-10-01 16:28 ` Dmitry Torokhov
2014-10-02 9:53 ` Mika Westerberg
2014-10-01 2:21 ` [PATCH v3 14/15] misc: at25: Make use of device property API Rafael J. Wysocki
[not found] ` <2074642.sV7QBxD3Ne-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-10-01 8:14 ` Arnd Bergmann
2014-10-01 8:14 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15084898.uePkciO2J1@wuerfel \
--to=arnd@arndb.de \
--cc=aaron.lu@intel.com \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dvhart@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.