All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ricardo Dias <rdias@suse.com>
To: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Why does messenger sends the address of himself and of the connecting peer
Date: Fri, 20 Oct 2017 16:25:18 +0100	[thread overview]
Message-ID: <1508513118.10018.8.camel@suse.com> (raw)

Hi,

In the current messenger protocol, upon accepting a new connection, the
messenger sends it's address and the connecting peer address along with
the banner string. Why does the connecting peer need these addresses?
Moreover, the connecting peer uses the connecting peer address (sent
from the server) to set as it's own address.

What happens if the network is rewriting addresses  because of NAT, or
whatever other strange reasons?

I also saw that the code that encodes these addresses have a comment
saying "// legacy". Should we remove these addresses from the new V2
protocol, or do we still need them?

Thanks,
Ricardo

-- 
Ricardo Dias
Senior Software Engineer - Storage Team
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton,
HRB 21284
(AG Nürnberg)

             reply	other threads:[~2017-10-20 15:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-20 15:25 Ricardo Dias [this message]
2017-10-20 15:30 ` Why does messenger sends the address of himself and of the connecting peer Jason Dillaman
2017-10-20 15:40 ` Sage Weil
2017-10-23  8:47   ` Ricardo Dias
2017-10-23 12:14     ` Sage Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508513118.10018.8.camel@suse.com \
    --to=rdias@suse.com \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.