From: Javier Celaya <javier.celaya@flexvm.es>
To: qemu-devel@nongnu.org
Cc: spice-devel <spice-devel@lists.freedesktop.org>,
flex.dev@nologin.es, Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE
Date: Thu, 08 Jan 2015 11:50:13 +0100 [thread overview]
Message-ID: <1508539.cfTQauU1Ry@javinlg> (raw)
Hello
Recently, SPICE included the lz4 compression algorithm. This patch adds
a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not
exist before the commit that added this compression algorithm, so it should be
guarded with conditional compilation. How do you think this should be done?
Wait for the next stable version of spice-server and check for
SPICE_SERVER_VERSION? Or add a specific flag?
Thank you
---
ui/spice-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 6467fa4..fb6534e 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -359,6 +359,7 @@ static const char *compression_names[] = {
[ SPICE_IMAGE_COMPRESS_QUIC ] = "quic",
[ SPICE_IMAGE_COMPRESS_GLZ ] = "glz",
[ SPICE_IMAGE_COMPRESS_LZ ] = "lz",
+ [ SPICE_IMAGE_COMPRESS_LZ4 ] = "lz4",
};
#define parse_compression(_name) \
parse_name(_name, "image compression", \
--
1.9.3
next reply other threads:[~2015-01-08 10:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 10:50 Javier Celaya [this message]
2015-01-08 11:28 ` [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE Gerd Hoffmann
2015-01-08 11:48 ` [Qemu-devel] [Spice-devel] " Fabio Fantoni
2015-01-08 12:00 ` Javier Celaya
2015-01-20 16:08 ` Christophe Fergeau
2015-01-23 14:06 ` Javier Celaya
2015-01-23 16:25 ` Eric Blake
2015-01-26 8:48 ` Javier Celaya
2015-01-26 16:25 ` Eric Blake
2015-01-27 8:26 ` Markus Armbruster
2015-01-28 16:54 ` Javier Celaya
2015-01-28 19:08 ` Markus Armbruster
2015-07-24 14:12 ` Fabio Fantoni
2015-07-27 6:12 ` Markus Armbruster
2015-10-09 6:45 ` Fabio Fantoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508539.cfTQauU1Ry@javinlg \
--to=javier.celaya@flexvm.es \
--cc=aliguori@amazon.com \
--cc=flex.dev@nologin.es \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.