From: Bastien Nocera <hadess@hadess.net>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] profiles/battery: Remove unused bas.[ch]
Date: Tue, 24 Oct 2017 00:13:57 +0200 [thread overview]
Message-ID: <1508796837.28409.5.camel@hadess.net> (raw)
In-Reply-To: <CABBYNZLJabUx4LJK-bhMekYx1SNS79U1y0J+7KcSCN6g8X_wYQ@mail.gmail.com>
On Mon, 2017-10-23 at 23:39 +0300, Luiz Augusto von Dentz wrote:
> Hi Bastian,
>
> On Mon, Oct 23, 2017 at 6:48 PM, Bastien Nocera <hadess@hadess.net>
> wrote:
> > The Battery Service characteristics are not children of the HoG
> > characteristics, so there's nothing to consume in the input
> > profile.
> > Remove that code which duplicated most of the battery profile
> > plugin.
>
> Id rather not do this, we actually do intend the maintain a small
> helper library that can be unit tested, what bt_bas lacks is just
> proper support of bt_gatt_client nothing else. Also for the record
> this would probably break BfA HoG qualification which requires
> battery
> service to be supported as well, Android code does not have any other
> bas implementation.
That's fine, we can leave this file around. What about the other
patches?
next prev parent reply other threads:[~2017-10-23 22:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 15:48 [PATCH v2 1/3] battery: Add BT SIG reserved numbers used by Battery Service Bastien Nocera
2017-10-23 15:48 ` [PATCH v2 2/3] profiles/battery: Add Bluetooth LE Battery service Bastien Nocera
2017-10-23 15:49 ` Bastien Nocera
2017-10-23 15:48 ` [PATCH v2 3/3] profiles/battery: Remove unused bas.[ch] Bastien Nocera
2017-10-23 20:39 ` Luiz Augusto von Dentz
2017-10-23 22:13 ` Bastien Nocera [this message]
2017-10-24 7:40 ` Luiz Augusto von Dentz
2017-10-24 8:04 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508796837.28409.5.camel@hadess.net \
--to=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.