From: James Bottomley <jejb@linux.vnet.ibm.com>
To: Don Brace <don.brace@microsemi.com>,
joseph.szczypek@hpe.com, gerry.morong@microsemi.com,
john.hall@microsemi.com, Kevin.Barnett@microsemi.com,
bader.alisaleh@microsemi.com, hch@infradead.org,
scott.teel@microsemi.com, Justin.Lindley@microsemi.com,
scott.benesh@microsemi.com, POSWALD@suse.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 02/12] hpsa: cleanup sas_phy structures in sysfs when unloading
Date: Mon, 23 Oct 2017 16:44:53 -0700 [thread overview]
Message-ID: <1508802293.3209.3.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <150853627417.28275.14954285884974003997.stgit@brunhilda>
On Fri, 2017-10-20 at 16:51 -0500, Don Brace wrote:
> From: Martin Wilck <mwilck@suse.de>
>
> I am resubmitting this patch on behalf of Martin Wilck
> with his permission.
>
> The original patch can be found here:
> https://www.spinics.net/lists/linux-scsi/msg102083.html
>
> This patch did not help until Hannes's
> commit 9441284fbc39 ("scsi-fixup-kernel-warning-during-rmmod")
> was applied to the kernel.
>
> --------------------------------------
> Original patch description from Martin:
> --------------------------------------
>
> When the hpsa module is unloaded using rmmod, dangling
> symlinks remain under /sys/class/sas_phy. Fix this by
> calling sas_phy_delete() rather than sas_phy_free (which,
> according to comments, should not be called for PHYs that
> have been set up successfully, anyway).
>
> Tested-by: Don Brace <don.brace@microsemi.com>
> Reviewed-by: Don Brace <don.brace@microsemi.com>
> Signed-off-by: Martin Wilck <mwilck@xxxxxxx>
Hey, what's this for a signoff? The original patch had the correct
email address; how did it get mangled like this?
James
next prev parent reply other threads:[~2017-10-23 23:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 21:51 [PATCH 00/12] hpsa updates Don Brace
2017-10-20 21:51 ` [PATCH 01/12] hpsa: destroy sas transport properties before scsi_host Don Brace
2017-10-20 21:51 ` [PATCH 02/12] hpsa: cleanup sas_phy structures in sysfs when unloading Don Brace
2017-10-23 23:44 ` James Bottomley [this message]
2017-10-24 15:08 ` Don Brace
2017-10-24 15:14 ` Martin K. Petersen
2017-10-20 21:51 ` [PATCH 03/12] hpsa: clear tmpdevice in scan thread Don Brace
2017-10-20 21:51 ` [PATCH 04/12] hpsa: add controller checkpoint Don Brace
2017-10-20 21:51 ` [PATCH 05/12] hpsa: update discovery polling Don Brace
2017-10-20 21:51 ` [PATCH 06/12] hpsa: change timeout for internal cmds Don Brace
2017-10-20 21:51 ` [PATCH 07/12] hpsa: correct smart path enabled Don Brace
2017-10-20 21:51 ` [PATCH 08/12] hpsa: update queue depth for externals Don Brace
2017-10-20 21:51 ` [PATCH 09/12] hpsa: reduce warning messages on device removal Don Brace
2017-10-20 21:52 ` [PATCH 10/12] hpsa: correct logical volume removal Don Brace
2017-10-20 21:52 ` [PATCH 11/12] hpsa: add enclosure logical identifier Don Brace
2017-10-20 21:52 ` [PATCH 12/12] hpsa: bump driver version Don Brace
2017-10-23 8:18 ` [PATCH 00/12] hpsa updates Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508802293.3209.3.camel@linux.vnet.ibm.com \
--to=jejb@linux.vnet.ibm.com \
--cc=Justin.Lindley@microsemi.com \
--cc=Kevin.Barnett@microsemi.com \
--cc=POSWALD@suse.com \
--cc=bader.alisaleh@microsemi.com \
--cc=don.brace@microsemi.com \
--cc=gerry.morong@microsemi.com \
--cc=hch@infradead.org \
--cc=john.hall@microsemi.com \
--cc=joseph.szczypek@hpe.com \
--cc=linux-scsi@vger.kernel.org \
--cc=scott.benesh@microsemi.com \
--cc=scott.teel@microsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.