All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: A good way to get CSI info to user-space?
Date: Tue, 24 Oct 2017 15:55:16 +0200	[thread overview]
Message-ID: <1508853316.2639.31.camel@sipsolutions.net> (raw)
In-Reply-To: <b52bbc61-f0b5-5e9a-cce3-011fd43e6c8d@candelatech.com>

On Tue, 2017-10-24 at 06:50 -0700, Ben Greear wrote:

> > We keep having this discussion. You need to fix this, it should be
> > really simple to fix this - just remove all checks for CONF_MONITOR
> > from ath10k and make it use WANT_MONITOR_VIF instead if it doesn't
> > already.
> 
> I don't recall having this discussion, 

I'm pretty sure I had this discussion about ath10k not liking virtual
monitor, but maybe it was with somebody else.

> but even if you can do a
> non-promiscuous monitor mode, you would have to end up having a bpf
> socket filter and packet socket, right?

True.

> Wouldn't that have a noticeable effect on performance on modest sized
> AP hardware?

Yes. I was planning to add the wifi BPF to fix that:
https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git/log/?h=bpf

You shouldn't think that building netlink messages is free though.
There's a lot more locking etc. going on there.

> > > mac80211_nl_send_opaque_event(mac80211-handle, int data-type, u8* data, int data_len);
> > 
> > I will not accept this upstream.
> 
> Thanks for letting me know up front, at least.
> 
> Anyone know if there is a useful way to stream events from debugfs
> and/or sysfs w/out having to busy-poll on it?

There's relayfs, which is kinda built for that. You could even use
netlink vendor events, but I don't really think netlink is appropriate
here.

johannes

  reply	other threads:[~2017-10-24 13:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 17:54 A good way to get CSI info to user-space? Ben Greear
2017-10-23 20:30 ` Johannes Berg
2017-10-23 20:59   ` Ben Greear
2017-10-24  5:54     ` Johannes Berg
2017-10-24 13:36       ` Ben Greear
2017-10-24 13:38         ` Johannes Berg
2017-10-24 13:50           ` Ben Greear
2017-10-24 13:55             ` Johannes Berg [this message]
2017-10-24 20:15               ` Ben Greear
2017-10-25 14:30               ` Zefir Kurtisi
2017-10-25 14:43                 ` Ben Greear
2017-10-25 15:35                   ` Zefir Kurtisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508853316.2639.31.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.