From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Rhys Kidd <rhyskidd@gmail.com>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [i-g-t] assembler: Fix bashism in run-test.sh
Date: Mon, 30 Oct 2017 12:51:05 +0200 [thread overview]
Message-ID: <1509360665.4757.0.camel@linux.intel.com> (raw)
In-Reply-To: <20171029002018.21167-1-rhyskidd@gmail.com>
On Sat, 2017-10-28 at 20:20 -0400, Rhys Kidd wrote:
> [[ a != b ]] is a bashism. As it's just comparing $1 to an empty string,
> use -n with a normal [ ].
>
> Noticed whilst testing meson builds. /bin/sh is apparently dash in Intel's CI.
>
> Also change the script to #!/bin/bash to avoid having to babysit bashism later.
Just leave the shebang as it is, then this is;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-30 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 0:20 [i-g-t] assembler: Fix bashism in run-test.sh Rhys Kidd
2017-10-29 0:39 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-10-30 10:51 ` Joonas Lahtinen [this message]
2017-10-30 13:09 ` [i-g-t v2] " Rhys Kidd
2017-10-30 17:59 ` Arkadiusz Hiler
2017-10-30 13:51 ` ✗ Fi.CI.BAT: failure for assembler: Fix bashism in run-test.sh (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509360665.4757.0.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rhyskidd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.