From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
Date: Tue, 31 Oct 2017 15:22:46 +0200 [thread overview]
Message-ID: <1509456166.7795.24.camel@linux.intel.com> (raw)
In-Reply-To: <20171030172927.18158-1-chris@chris-wilson.co.uk>
On Mon, 2017-10-30 at 17:29 +0000, Chris Wilson wrote:
> To quote kbuild/makefiles.txt:
>
> cc-disable-warning checks if gcc supports a given warning and returns
> the commandline switch to disable it. This special function is needed,
> because gcc 4.4 and later accept any unknown -Wno-* option and only
> warn about it if there is another warning in the source file.
>
> This is exactly what we were trying to achieve with cc-option -Wno-foo and
> failed miserably.
>
> Reported-by: kbuild-all@01.org
> Fixes: 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set warnings to full")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
Poor person who greps for "-Wno-", should we add comment
"# -Wno-whatever" at the end of each line?
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-10-31 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 17:29 [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo" Chris Wilson
2017-10-30 17:41 ` Ville Syrjälä
2017-10-30 21:25 ` Chris Wilson
2017-10-30 17:51 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-30 18:57 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-30 22:43 ` ✓ Fi.CI.BAT: " Patchwork
2017-10-30 23:45 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-31 13:22 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509456166.7795.24.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.