From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753639AbdJaPsD (ORCPT <rfc822;w@1wt.eu>);
        Tue, 31 Oct 2017 11:48:03 -0400
Received: from smtprelay0013.hostedemail.com ([216.40.44.13]:45329 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751876AbdJaPsC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 31 Oct 2017 11:48:02 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2110:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3867:3868:3870:3871:3872:4321:5007:6120:10004:10400:10848:11232:11658:11914:12296:12740:12760:12895:13069:13071:13311:13357:13439:14180:14659:14721:21060:21080:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: coach38_8014551d21e02
X-Filterd-Recvd-Size: 1386
Message-ID: <1509464878.31043.2.camel@perches.com>
Subject: Re: [RFC PATCH 1/2] scripts: warn about invalid MAINTAINER patterns
From: Joe Perches <joe@perches.com>
To: Tom Saeger <tom.saeger@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Date: Tue, 31 Oct 2017 08:47:58 -0700
In-Reply-To: <a35fc984e206942eec67302726f5b642c68909b9.1509401037.git.tom.saeger@oracle.com>
References: <cover.1509401037.git.tom.saeger@oracle.com>
         <a35fc984e206942eec67302726f5b642c68909b9.1509401037.git.tom.saeger@oracle.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.26.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2017-10-31 at 09:46 -0500, Tom Saeger wrote:
> Add get_maintainer.pl option to warn about invalid
> "F" and "X" patterns found in MAINTAINERS file(s).

Hi Tom.

I've had a similar script for many years.

This implementation is very inefficient as it runs
git ls-files once for each file pattern.

It's much more efficient to do a global git ls-files
once and store the result and then do a local grep
for pattern matches.

cheers, Joe