From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv4] package/glibc: switch to using the maintenance branch
Date: Tue, 31 Oct 2017 16:23:24 +0000 [thread overview]
Message-ID: <1509467004.4869.23.camel@synopsys.com> (raw)
In-Reply-To: <20171030222654.GB3150@scaer>
Hi Yann,
On Mon, 2017-10-30 at 23:26 +0100, Yann E. MORIN wrote:
> Alexey, All,
>
> On 2017-10-30 11:07 +0000, Alexey Brodkin spake thusly:
> >
> > On Sun, 2017-10-29 at 15:52 +0100, Thomas Petazzoni wrote:
> > >
> > > On Sun, 29 Oct 2017 10:52:48 +0100, Yann E. MORIN wrote:
> > > >
> > > > glibc upstream has ruled against doing regular point-releases, but they
> > > > do have a lot of interesting and important fixes for regressions and
> > > > security.
> [--SNIP--]
> >
> > Sorry for a bit late reply - was catching up after ELCE journey.
>
> Yup, same here! Was nice seeing you again there. :-)_
>
> >
> > Back in the day when we added support of Glibc for ARC we intentionally
> > left glibc patches where they were so they were applid to ARC version of glibc as well.
> >
> > Now those patches are gone. I'm wondering if some of them were fixing real problems
> > discovered in Buildroot?
>
> When he bumped the version to 2.26, Romain noticed a few issues, and
> cherry-picked the relevant few patches. So yes, they were for real
> problems.
>
> >
> > If so then we may want to get them back for ARC until we
> > rebase ARC glibc on top of more recent upstream version where some if not all of those
> > patches are already integrated.
> >
> > IIRC the patches in question were applied to ARC's glibc version without issues,
> > i.e. corresponding commits were not there yet for us.
>
> The issue is that there are now 73^W75 patches on the 2.26 maintance
> branch, and we don't really know what to use/not to use. So we decided
> to use all of it and do it via a git clone.
>
> Since you, Synopsys, are providing glibc from a git branch as well (I
> just noticed that there was a release tagged a few days ago, btw), I
> think it is up to you to base your branch on whatever upstream commit
> you believe makes sense, and backport/cherry-pick/merge whatever you see
> fit in your branch.
Sure, makes sense.
So basically what we may do is to cherry-pick all commits from glibc's
stable branch to our "release" branch so that we're not blindly rebasing
on top of master branch but keep our "stable" code-base based on not up-to-date
upstream master and only add fixes on top of it.
> Definitiely, the idea is to not cary in Buldroot a patch that is in the
> upstream branch.
>
> I think we could very well get an exception for a very few patches,
> specific to the ARC port, to live in package/glibc/arc-2017.09-eng010/
> if need be, for the upcoming release, though.
>
> Hopefully, that situation will resolve itself as soon as ARC support
> lands upstream. ;-)
Well I hope so :)
-Alexey
prev parent reply other threads:[~2017-10-31 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 9:52 [Buildroot] [PATCHv4] package/glibc: switch to using the maintenance branch Yann E. MORIN
2017-10-29 10:23 ` Romain Naour
2017-10-29 14:52 ` Thomas Petazzoni
2017-10-30 11:07 ` Alexey Brodkin
2017-10-30 22:26 ` Yann E. MORIN
2017-10-31 16:23 ` Alexey Brodkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509467004.4869.23.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.