From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Stefan Stanacar <stefanx.stanacar@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 21/21] lib/oeqa: add a restart method for base class and use it for build tests
Date: Fri, 23 Aug 2013 16:41:16 +0100 [thread overview]
Message-ID: <1509485.XBvO8KBohd@helios> (raw)
In-Reply-To: <6d7bb8409eb99b415d2500c5146a6b0c7eac2e7f.1377269486.git.stefanx.stanacar@intel.com>
On Friday 23 August 2013 18:31:01 Stefan Stanacar wrote:
> This can be used by tests to restart the target
> (useful for passing extra qemuparams, like more RAM)
>
> Build projects like cvs/iptables can take 15min+ on
> qemu targets with the default RAM, and sudoku fails
> with out of memory, so use this there.
>
> Signed-off-by: Stefan Stanacar <stefanx.stanacar@intel.com>
> ---
> meta/lib/oeqa/oetest.py | 7 +++++++
> meta/lib/oeqa/runtime/buildcvs.py | 2 ++
> meta/lib/oeqa/runtime/buildiptables.py | 2 ++
> meta/lib/oeqa/runtime/buildsudoku.py | 2 ++
> 4 files changed, 13 insertions(+)
>
> diff --git a/meta/lib/oeqa/oetest.py b/meta/lib/oeqa/oetest.py
> index e694c0b..c9dc5dc 100644
> --- a/meta/lib/oeqa/oetest.py
> +++ b/meta/lib/oeqa/oetest.py
> @@ -81,6 +81,13 @@ class oeRuntimeTest(unittest.TestCase):
> else:
> return False
>
> + @classmethod
> + def restartTarget(self,params=None):
> +
> + if oeRuntimeTest.tc.qemu.restart(params):
> + oeRuntimeTest.tc.target.host = oeRuntimeTest.tc.qemu.ip
> + else:
> + raise Exception("Restarting target failed")
>
>
> def getmodule(pos=2):
> diff --git a/meta/lib/oeqa/runtime/buildcvs.py
> b/meta/lib/oeqa/runtime/buildcvs.py index 9bf764d..f024dfa 100644
> --- a/meta/lib/oeqa/runtime/buildcvs.py
> +++ b/meta/lib/oeqa/runtime/buildcvs.py
> @@ -10,6 +10,7 @@ class BuildCvsTest(oeRuntimeTest):
>
> @classmethod
> def setUpClass(self):
> + self.restartTarget("-m 512")
> self.project = TargetBuildProject(oeRuntimeTest.tc.target,
>
> "http://ftp.gnu.org/non-gnu/cvs/source/feature/1.12.13/cvs-1.12.13.tar.bz2"
> ) self.project.download_archive()
> @@ -28,3 +29,4 @@ class BuildCvsTest(oeRuntimeTest):
> @classmethod
> def tearDownClass(self):
> self.project.clean()
> + self.restartTarget()
> diff --git a/meta/lib/oeqa/runtime/buildiptables.py
> b/meta/lib/oeqa/runtime/buildiptables.py index 50faf5d..88ece3b 100644
> --- a/meta/lib/oeqa/runtime/buildiptables.py
> +++ b/meta/lib/oeqa/runtime/buildiptables.py
> @@ -10,6 +10,7 @@ class BuildIptablesTest(oeRuntimeTest):
>
> @classmethod
> def setUpClass(self):
> + self.restartTarget("-m 512")
> self.project = TargetBuildProject(oeRuntimeTest.tc.target,
>
> "http://netfilter.org/projects/iptables/files/iptables-1.4.13.tar.bz2")
> self.project.download_archive()
> @@ -28,3 +29,4 @@ class BuildIptablesTest(oeRuntimeTest):
> @classmethod
> def tearDownClass(self):
> self.project.clean()
> + self.restartTarget()
> diff --git a/meta/lib/oeqa/runtime/buildsudoku.py
> b/meta/lib/oeqa/runtime/buildsudoku.py index 61dc1ff..0a7306d 100644
> --- a/meta/lib/oeqa/runtime/buildsudoku.py
> +++ b/meta/lib/oeqa/runtime/buildsudoku.py
> @@ -10,6 +10,7 @@ class SudokuTest(oeRuntimeTest):
>
> @classmethod
> def setUpClass(self):
> + self.restartTarget("-m 512")
> self.project = TargetBuildProject(oeRuntimeTest.tc.target,
>
> "http://downloads.sourceforge.net/project/sudoku-savant/sudoku-savant/sudok
> u-savant-1.3/sudoku-savant-1.3.tar.bz2") self.project.download_archive()
> @@ -25,3 +26,4 @@ class SudokuTest(oeRuntimeTest):
> @classmethod
> def tearDownClass(self):
> self.project.clean()
> + self.restartTarget()
Could you please you move the function addition earlier in the series and
merge the test changes into the earlier commits that added them?
Thanks,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
prev parent reply other threads:[~2013-08-23 15:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 15:30 [PATCH 00/21] Some new runtime tests or fixes Stefan Stanacar
2013-08-23 15:30 ` [PATCH 01/21] lib/oeqa/runtime: add basic test for x32 images Stefan Stanacar
2013-08-23 15:30 ` [PATCH 02/21] lib/oeqa/runtime: add test for perl Stefan Stanacar
2013-08-23 15:30 ` [PATCH 03/21] lib/oeqa/runtime: add a test for ldd Stefan Stanacar
2013-08-23 15:30 ` [PATCH 04/21] lib/oeqa/runtime: add new logrotate test Stefan Stanacar
2013-08-23 15:30 ` [PATCH 05/21] lib/oeqa/runtime: add new skeletoninit test Stefan Stanacar
2013-08-23 15:30 ` [PATCH 06/21] lib/oeqa/runtime: add new PAM support test Stefan Stanacar
2013-08-23 15:30 ` [PATCH 07/21] lib/oeqa/runtime: add new scp test Stefan Stanacar
2013-08-23 15:30 ` [PATCH 08/21] lib/oeqa/utils: new file: httpserver.py useful for serving files over HTTP to the target Stefan Stanacar
2013-08-23 15:30 ` [PATCH 09/21] lib/oeqa/utils: qemurunner: save host IP address Stefan Stanacar
2013-08-23 15:30 ` [PATCH 10/21] oeqa/utils/decorators: return the decorated method Stefan Stanacar
2013-08-23 15:30 ` [PATCH 11/21] lib/oeqa/runtime: smart: add new smart tests Stefan Stanacar
2013-08-23 15:30 ` [PATCH 12/21] lib/oeqa/utils: targetbuild: Add helper class for building packages on target Stefan Stanacar
2013-08-23 15:30 ` [PATCH 13/21] lib/oeqa/runtime: add iptables, cvs and sudoku projects build tests " Stefan Stanacar
2013-08-23 15:30 ` [PATCH 14/21] lib/oeqa/runtime: add adjust date and time test Stefan Stanacar
2013-08-23 15:30 ` [PATCH 15/21] lib/oeqa/runtime: add vncserver for target test Stefan Stanacar
2013-08-23 15:30 ` [PATCH 16/21] classess/testimage: change default test suites Stefan Stanacar
2013-08-23 15:30 ` [PATCH 17/21] oeqa/utils/targetbuild: change download to use bitbake's fetcher Stefan Stanacar
2013-08-23 15:38 ` Paul Eggleton
2013-08-23 15:30 ` [PATCH 18/21] lib/oeqa/runtime: rpm: add install and erase tests Stefan Stanacar
2013-08-23 15:30 ` [PATCH 19/21] lib/oeqa: change behaviour for unskippable tests Stefan Stanacar
2013-08-23 15:31 ` [PATCH 20/21] lib/oeqa/utils: qemurunner: improve kill and restart Stefan Stanacar
2013-08-23 15:31 ` [PATCH 21/21] lib/oeqa: add a restart method for base class and use it for build tests Stefan Stanacar
2013-08-23 15:41 ` Paul Eggleton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509485.XBvO8KBohd@helios \
--to=paul.eggleton@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=stefanx.stanacar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.