From: "Einar Jón Gunnarsson" <tolvupostur@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] BR2_REPRODUCIBLE issues
Date: Fri, 3 Nov 2017 07:40:41 -0700 (MST) [thread overview]
Message-ID: <1509720041684-0.post@n4.nabble.com> (raw)
Hello all.
I've been using BR2_REPRODUCIBLE, and it mostly works.
But when it is using a git repo, I have the following issues with creating
SOURCE_DATE_EPOCH:
1) It uses $(GIT), but the GIT variable is only defined in line 487:
"include package/Makefile.in".
Note that this is done around line 250 in $(TOPDIR)/Makefile, so sometimes
$(GIT) is unset then getting BR2_VERSION_GIT_EPOCH
2) It always uses the last git commit to calculate the date. So any commit
changes the timestamp, while the non-git timestamp stays the same.
This makes the whole thing almost useless.
If the git log command could take a parameter, you could make reproducible
builds based on e.g. tag 2017.08, which would be much more useful.
Regards,
Einar J?n
An idea for a patch made against origin/next - feel free to do whatever with
it.
if BR2_REPRODUCIBLE_CUSTOM_REPO_VERSION is empty, the behaviour is unchanged
from before.
Maybe setting the default value of BR2_REPRODUCIBLE_CUSTOM_REPO_VERSION to
the last major tag version might make sense.
------
next reply other threads:[~2017-11-03 14:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 14:40 Einar Jón Gunnarsson [this message]
2017-11-03 20:15 ` [Buildroot] BR2_REPRODUCIBLE issues Peter Korsgaard
2017-11-04 19:53 ` Arnout Vandecappelle
2017-11-04 20:49 ` Peter Korsgaard
2017-11-04 22:24 ` Thomas Petazzoni
2017-11-05 8:46 ` Yann E. MORIN
2017-11-06 9:43 ` Einar Jón
2017-11-06 17:50 ` Yann E. MORIN
2017-11-06 20:39 ` Peter Korsgaard
2017-11-06 22:50 ` Arnout Vandecappelle
2017-11-08 18:00 ` Yann E. MORIN
2017-11-08 18:59 ` Peter Korsgaard
2017-11-08 22:07 ` Arnout Vandecappelle
2017-11-06 21:34 ` Arnout Vandecappelle
2017-11-06 21:37 ` Yann E. MORIN
2017-11-05 8:35 ` Yann E. MORIN
2017-11-05 8:54 ` Peter Korsgaard
2017-11-05 8:59 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509720041684-0.post@n4.nabble.com \
--to=tolvupostur@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.