From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:57492 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751747AbdKFJm4 (ORCPT ); Mon, 6 Nov 2017 04:42:56 -0500 Subject: Patch "xen/manage: correct return value check on xenbus_scanf()" has been added to the 3.18-stable tree To: JBeulich@suse.com, alexander.levin@verizon.com, boris.ostrovsky@oracle.com, gregkh@linuxfoundation.org, jbeulich@suse.com, jgross@suse.com Cc: , From: Date: Mon, 06 Nov 2017 10:42:47 +0100 Message-ID: <1509961367110168@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled xen/manage: correct return value check on xenbus_scanf() to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: xen-manage-correct-return-value-check-on-xenbus_scanf.patch and it can be found in the queue-3.18 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From foo@baz Mon Nov 6 10:42:09 CET 2017 From: Jan Beulich Date: Sat, 7 Oct 2017 22:38:00 +0000 Subject: xen/manage: correct return value check on xenbus_scanf() From: Jan Beulich [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ] A negative return value indicates an error; in fact the function at present won't ever return zero. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Signed-off-by: Boris Ostrovsky Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/xen/manage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/xen/manage.c +++ b/drivers/xen/manage.c @@ -272,7 +272,7 @@ static void sysrq_handler(struct xenbus_ err = xenbus_transaction_start(&xbt); if (err) return; - if (!xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key)) { + if (xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key) < 0) { pr_err("Unable to read sysrq code in control/sysrq\n"); xenbus_transaction_end(xbt, 1); return; Patches currently in stable-queue which might be from JBeulich@suse.com are queue-3.18/xen-manage-correct-return-value-check-on-xenbus_scanf.patch