From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Foss Subject: Re: [PATCH hwc] Android: add CleanSpec.mk Date: Mon, 06 Nov 2017 12:16:12 +0100 Message-ID: <1509966972.2080.1.camel@collabora.com> References: <20171103044508.25104-1-cwhuang@linux.org.tw> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1409217959==" Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 778096E30E for ; Mon, 6 Nov 2017 11:16:18 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring , Chih-Wei Huang Cc: Chih-Wei Huang , dri-devel List-Id: dri-devel@lists.freedesktop.org --===============1409217959== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-uUUBWEwm8KOUOCILudVQ" --=-uUUBWEwm8KOUOCILudVQ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey Rob, On Fri, 2017-11-03 at 07:35 -0500, Rob Herring wrote: > On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang org> wrote: > > The file contains rules that are executed on incremental builds. > > Since commit 4f7dc9b6 the library was moved to /vendor so > > the old file must be removed. > >=20 > > Signed-off-by: Chih-Wei Huang > > --- > > CleanSpec.mk | 1 + > > 1 file changed, 1 insertion(+) > > create mode 100644 CleanSpec.mk > >=20 > > diff --git a/CleanSpec.mk b/CleanSpec.mk > > new file mode 100644 > > index 0000000..99dcecd > > --- /dev/null > > +++ b/CleanSpec.mk > > @@ -0,0 +1 @@ > > +$(call add-clean-step, rm -rf > > $(TARGET_OUT)/lib*/hw/hwcomposer.drm.so) >=20 > Seems a bit silly to add forever an explicit file to clean for a > transient problem. >=20 While transient, if maintaining multuple Android versions it may still stick around for quite some time. That being said, I don't have much of an opinion about this. Rob. --=-uUUBWEwm8KOUOCILudVQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJaAER9AAoJELeaC2oR7vcnhewP/1Z+GtnifGhxTtz+rfW3SGet S9If2mDlkyTPJutrDfXEWwqNGfajAX5sowGPjOrnwSqhnBZhtrmo5KymSxJQS5Wh HLpcd4cU3cMm4KEdXTA6K/RT+6w9u+otfNgVUTWpGPkvKtcjyuhZe5ez+Ay4Mnoq E6L5tXrQBs/ylxukSpwmrn74E5Vt06fpPjuSYjCs2Bi4C8tBqmFduICqz8YsBDKL 5BgJDyiDKCjSo4/Y5gWDU1zPPDJTK+ilazvvUbLRGD2qjQIjmRftIeHJ6A57I+Le 0mOt07rbkkIoaVyyTlKUfDAXg8kfASjDdngVsohKLQDbLbOOekWzGiXD+bwy4eKU qyRoFYU7DyzP/lFkAfVjMTQSqZcCh7by5iF3gBeUKjiGY5q44CqviGU2M7Zyac2j ad/OjrUJwY440syksc1WL8Fj3n0O5Piz6eraG4RA4Xm+IrkV5cM5+AYfrcb+kw82 tfJuiqTqqt1zyLnfSEURmkQsKGhui4QeG1GB8PoItV82t1ELMTnDYFSuMc76opoj 4gEnNxphDzwHF2+B54NSDwePexkrc+O16XHaxwSbuX48ikN1vbuWk1t09MghrEQI Y9Yp2LBDMqZoccIBFA+DYZc6SjAT3koC7colC8POLxBXJmpw0ELHJx/TbIyxG38i UnghtPucer0SfqdAoAK8 =Ixvo -----END PGP SIGNATURE----- --=-uUUBWEwm8KOUOCILudVQ-- --===============1409217959== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1409217959==--