All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Oscar Mateo <oscar.mateo@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [RFC PATCH 02/20] drm/i915: Move a bunch of workaround-related code to its own file
Date: Mon, 06 Nov 2017 14:47:51 +0200	[thread overview]
Message-ID: <1509972471.5418.67.camel@linux.intel.com> (raw)
In-Reply-To: <150997214863.3226.12185306462778142235@mail.alporthouse.com>

On Mon, 2017-11-06 at 12:42 +0000, Chris Wilson wrote:
> Quoting Oscar Mateo (2017-11-03 18:09:30)
> > This has grown to be a sizable amount of code, so move it to
> > its own file before we try to refactor anything. For the moment,
> > we are leaving behind the WA BB code and the WAs that get applied
> > (incorrectly) in init_clock_gating, but we will deal with it later.
> > 
> > v2: Use intel_ prefix for code that deals with the hardware (Chris)
> > v3: Rebased
> > 
> > Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> 
> I would like to start on this reclassifications of w/a early; even just
> moving the current set of register writes into the right groups should
> be a massive help wrt to our confused init ordering.
> 
> Anyone object to moving the existing code around before we get the
> universal solution?

Nope, I was actually going to suggest getting the first patches merged
first. Then it'll then be easier to spin RFCs.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-11-06 12:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 18:09 [RFC PATCH v5 00/20] Refactor HW workaround code Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 01/20] drm/i915: Remove Gen9 WAs with no effect Oscar Mateo
2017-11-06 12:40   ` Chris Wilson
2017-11-03 18:09 ` [RFC PATCH 02/20] drm/i915: Move a bunch of workaround-related code to its own file Oscar Mateo
2017-11-06 12:42   ` Chris Wilson
2017-11-06 12:47     ` Joonas Lahtinen [this message]
2017-11-03 18:09 ` [RFC PATCH 03/20] drm/i915: Split out functions for different kinds of workarounds Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 04/20] drm/i915: Transform context WAs into static tables Oscar Mateo
2017-11-06 11:59   ` Joonas Lahtinen
2017-11-06 18:54     ` Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 05/20] drm/i915: Transform GT " Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 06/20] drm/i915: Transform Whitelist " Oscar Mateo
2017-11-03 20:43   ` [RFC PATCH v2] " Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 07/20] drm/i915: Create a new category of display WAs Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 08/20] drm/i915: Print all workaround types correctly in debugfs Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 09/20] drm/i915: Do not store the total counts of WAs Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 10/20] drm/i915: Move WA BB stuff to the workarounds file as well Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 11/20] drm/i915/cnl: Move GT and Display workarounds from init_clock_gating Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 12/20] drm/i915/gen9: " Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 13/20] drm/i915/cfl: " Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 14/20] drm/i915/glk: " Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 15/20] drm/i915/kbl: " Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 16/20] drm/i915/bxt: " Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 17/20] drm/i915/skl: " Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 18/20] drm/i915/chv: " Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 19/20] drm/i915/bdw: " Oscar Mateo
2017-11-03 18:09 ` [RFC PATCH 20/20] drm/i915: Document the i915_workarounds file Oscar Mateo
2017-11-03 18:37 ` ✗ Fi.CI.BAT: failure for Refactor HW workaround code (rev5) Patchwork
2017-11-03 21:05 ` ✗ Fi.CI.BAT: failure for Refactor HW workaround code (rev6) Patchwork
2017-11-03 21:51 ` [RFC PATCH v5 00/20] Refactor HW workaround code Oscar Mateo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509972471.5418.67.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=oscar.mateo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.