All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: allan <allan@asix.com.tw>,
	Colin Ian King <colin.king@canonical.com>,
	"David S . Miller" <davem@davemloft.net>,
	Philippe Reynes <tremyfr@gmail.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Kostya Serebryany <kcc@google.com>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Dean Jenkins <Dean_Jenkins@mentor.com>,
	Peter Chen <peter.chen@nxp.com>,
	LKML <linux-kernel@vger.kernel.org>,
	USB list <linux-usb@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend
Date: Mon, 06 Nov 2017 17:32:57 +0100	[thread overview]
Message-ID: <1509985977.2024.41.camel@suse.com> (raw)
In-Reply-To: <CAAeHK+y9GTPPjL2xTasun_e9M7jdE98DCGHWFtGF=JTPzLYOyw@mail.gmail.com>

Am Montag, den 06.11.2017, 17:05 +0100 schrieb Andrey Konovalov:
> On Mon, Nov 6, 2017 at 4:20 PM, Oliver Neukum <oneukum@suse.com> wrote:
> > 

> I do have a way to reproduce this.
> 
> As far as I understand, for this particular device ax88172_bind() is
> called, which doesn't assign anything to dev->driver_priv, so that's
> why it is NULL in suspend() and resume().

Thanks and ouch. That means it never worked for those devices.
That makes this a rather serious bug and your fix is right.

	Regards
		Oliver

      reply	other threads:[~2017-11-06 16:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 20:26 [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend Andrey Konovalov
2017-11-04 13:42 ` David Miller
2017-11-06  9:49 ` Oliver Neukum
2017-11-06 12:30   ` Andrey Konovalov
2017-11-06 15:20     ` Oliver Neukum
2017-11-06 16:05       ` Andrey Konovalov
2017-11-06 16:32         ` Oliver Neukum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509985977.2024.41.camel@suse.com \
    --to=oneukum@suse.com \
    --cc=Dean_Jenkins@mentor.com \
    --cc=allan@asix.com.tw \
    --cc=andreyknvl@google.com \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=dvyukov@google.com \
    --cc=gerg@linux-m68k.org \
    --cc=kcc@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peter.chen@nxp.com \
    --cc=tremyfr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.