All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bean Huo <beanhuo@iokpp.de>
To: Can Guo <can.guo@oss.qualcomm.com>,
	avri.altman@wdc.com, bvanassche@acm.org,  beanhuo@micron.com,
	peter.wang@mediatek.com, martin.petersen@oracle.com,
	 mani@kernel.org
Cc: linux-scsi@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
	 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 05/12] scsi: ufs: core: Add debugfs entries for TX Equalization params
Date: Mon, 23 Mar 2026 10:16:34 +0100	[thread overview]
Message-ID: <150ea7ea4a7f0facfb480b4bb6fbc65c13d544e7.camel@iokpp.de> (raw)
In-Reply-To: <20260321031021.1722459-6-can.guo@oss.qualcomm.com>

On Fri, 2026-03-20 at 20:10 -0700, Can Guo wrote:
> Add debugfs support for UFS TX Equalization and UFS TX Equalization
> Training (EQTR) to facilitate runtime inspection of link quality. These
> entries allow developers to monitor and optimize TX Equalization
> parameters and EQTR records during live operation.
> 
> The debugfs entries are organized on a per-gear basis under the HBA's
> debugfs root. Since TX EQTR is only defined for High Speed Gear 4 (HS-G4)
> and above, EQTR-related entries are explicitly excluded for HS-G1
> through HS-G3 to avoid exposing unsupported attributes.
> 
> The ufshcd's debugfs folder structure will look like below:
> 
> /sys/kernel/debug/ufshcd/*ufs*/
> > --tx_eq_hs_gear1/
> >   |--device_tx_eq_params
> >   |--host_tx_eq_params
> > --tx_eq_hs_gear2/
> > --tx_eq_hs_gear3/
> > --tx_eq_hs_gear4/
> > --tx_eq_hs_gear5/
> > --tx_eq_hs_gear6/
>    |--device_tx_eq_params
>    |--device_tx_eqtr_record
>    |--host_tx_eq_params
>    |--host_tx_eqtr_record
> 
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> Signed-off-by: Can Guo <can.guo@oss.qualcomm.com>

Reviewed-by: Bean Huo <beanhuo@micron.com>

  reply	other threads:[~2026-03-23  9:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-21  3:10 [PATCH v4 00/12] scsi: ufs: Add TX Equalization support for UFS 5.0 Can Guo
2026-03-21  3:10 ` [PATCH v4 01/12] scsi: ufs: core: Introduce a new ufshcd vops negotiate_pwr_mode() Can Guo
2026-03-23  9:10   ` Bean Huo
2026-03-21  3:10 ` [PATCH v4 02/12] scsi: ufs: core: Pass force_pmc to ufshcd_config_pwr_mode() as a parameter Can Guo
2026-03-23  9:11   ` Bean Huo
2026-03-21  3:10 ` [PATCH v4 03/12] scsi: ufs: core: Add UFS_HS_G6 and UFS_HS_GEAR_MAX to enum ufs_hs_gear_tag Can Guo
2026-03-23  9:11   ` Bean Huo
2026-03-21  3:10 ` [PATCH v4 04/12] scsi: ufs: core: Add support for TX Equalization Can Guo
2026-03-22  9:48   ` Bean Huo
2026-03-22 14:26     ` Bean Huo
2026-03-23  6:05       ` Can Guo
2026-03-23  9:15   ` Bean Huo
2026-03-24  7:46   ` Peter Wang (王信友)
2026-03-24 10:09     ` Can Guo
2026-03-24 11:54       ` Peter Wang (王信友)
2026-03-24 12:32         ` Can Guo
2026-03-21  3:10 ` [PATCH v4 05/12] scsi: ufs: core: Add debugfs entries for TX Equalization params Can Guo
2026-03-23  9:16   ` Bean Huo [this message]
2026-03-21  3:10 ` [PATCH v4 06/12] scsi: ufs: core: Add helpers to pause and resume command processing Can Guo
2026-03-23  9:17   ` Bean Huo
2026-08-13 22:29   ` sashiko-bot
2026-03-21  3:10 ` [PATCH v4 07/12] scsi: ufs: core: Add support to retrain TX Equalization via debugfs Can Guo
2026-03-22 13:36   ` Bean Huo
2026-03-23  6:13     ` Can Guo
2026-03-23  9:21   ` Bean Huo
2026-03-21  3:10 ` [PATCH v4 08/12] scsi: ufs: ufs-qcom: Fixup PAM-4 TX L0_L1_L2_L3 adaptation pattern length Can Guo
2026-03-23  9:22   ` Bean Huo
2026-03-21  3:10 ` [PATCH v4 09/12] scsi: ufs: ufs-qcom: Implement vops tx_eqtr_notify() Can Guo
2026-03-23  9:23   ` Bean Huo
2026-03-21  3:10 ` [PATCH v4 10/12] scsi: ufs: ufs-qcom: Implement vops get_rx_fom() Can Guo
2026-03-23  9:24   ` Bean Huo
2026-03-21  3:10 ` [PATCH v4 11/12] scsi: ufs: ufs-qcom: Implement vops apply_tx_eqtr_settings() Can Guo
2026-03-23  9:24   ` Bean Huo
2026-03-21  3:10 ` [PATCH v4 12/12] scsi: ufs: ufs-qcom: Enable TX Equalization Can Guo
2026-03-23  9:25   ` Bean Huo
2026-03-23 16:50 ` [PATCH v4 00/12] scsi: ufs: Add TX Equalization support for UFS 5.0 Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150ea7ea4a7f0facfb480b4bb6fbc65c13d544e7.camel@iokpp.de \
    --to=beanhuo@iokpp.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=can.guo@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.wang@mediatek.com \
    --cc=quic_nguyenb@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.