diff for duplicates of <1510071472.2656.15.camel@wdc.com> diff --git a/a/1.txt b/N1/1.txt index 7a68b27..fabeb7e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,11 +1,12 @@ -T24gVHVlLCAyMDE3LTExLTA3IGF0IDE4OjE1ICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gTGFz -dCB0aW1lLCB5b3UgZGlkbid0IG1lbnRpb24gdGhlIHRhcmdldCBwYXRjaCBmb3Igc2V0dGluZyBp -dHMNCj4gY2FuX3F1ZXVlIGFzIDEsIHNvIEkgdGhpbmsgeW91IGNhbid0IHJlcHJvZHVjZSB0aGUg -aXNzdWUgb24gdXBzdHJlYW0NCj4ga2VybmVsIHdpdGhvdXQgb3V0LW9mLXRyZWUgcGF0Y2guIFRo -ZW4gbG9va3MgaXQgaXMgYW5vdGhlciBpc3N1ZSwNCj4gYW5kIHdlIGFyZSBtYWtpbmcgcHJvZ3Jl -c3MgYWN0dWFsbHkuDQoNCklmIEkgZG9uJ3QgdHJ1c3QgYSBwYXRjaCBJIGludHJvZHVjZSBhZGRp -dGlvbmFsIHRlc3RzLiBUaGUgZmFjdCB0aGF0IEkNCm1vZGlmaWVkIHRoZSBTUlAgaW5pdGlhdG9y -IGJlZm9yZSB0aGlzIGhhbmcgb2NjdXJyZWQgZG9lcyBub3QgbWVhbiB0aGF0IHRoZQ0KYXBwcm9h -Y2ggb2YgeW91ciBwYXRjaCBpcyBmaW5lLiBXaGF0IHRoaXMgbWVhbnMgaXMgdGhhdCBhbGwgeW91 -ciBwYXRjaCBkb2VzDQppcyB0byByZWR1Y2UgdGhlIHJhY2Ugd2luZG93IGFuZCB0aGF0IHRoZXJl -IGlzIHN0aWxsIGEgcmFjZSB3aW5kb3cuDQoNCkJhcnQu +On Tue, 2017-11-07 at 18:15 +0800, Ming Lei wrote: +> Last time, you didn't mention the target patch for setting its +> can_queue as 1, so I think you can't reproduce the issue on upstream +> kernel without out-of-tree patch. Then looks it is another issue, +> and we are making progress actually. + +If I don't trust a patch I introduce additional tests. The fact that I +modified the SRP initiator before this hang occurred does not mean that the +approach of your patch is fine. What this means is that all your patch does +is to reduce the race window and that there is still a race window. + +Bart. diff --git a/a/content_digest b/N1/content_digest index 14121d1..3f661bd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -15,16 +15,17 @@ " loberman@redhat.com <loberman@redhat.com>\0" "\00:1\0" "b\0" - "T24gVHVlLCAyMDE3LTExLTA3IGF0IDE4OjE1ICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gTGFz\n" - "dCB0aW1lLCB5b3UgZGlkbid0IG1lbnRpb24gdGhlIHRhcmdldCBwYXRjaCBmb3Igc2V0dGluZyBp\n" - "dHMNCj4gY2FuX3F1ZXVlIGFzIDEsIHNvIEkgdGhpbmsgeW91IGNhbid0IHJlcHJvZHVjZSB0aGUg\n" - "aXNzdWUgb24gdXBzdHJlYW0NCj4ga2VybmVsIHdpdGhvdXQgb3V0LW9mLXRyZWUgcGF0Y2guIFRo\n" - "ZW4gbG9va3MgaXQgaXMgYW5vdGhlciBpc3N1ZSwNCj4gYW5kIHdlIGFyZSBtYWtpbmcgcHJvZ3Jl\n" - "c3MgYWN0dWFsbHkuDQoNCklmIEkgZG9uJ3QgdHJ1c3QgYSBwYXRjaCBJIGludHJvZHVjZSBhZGRp\n" - "dGlvbmFsIHRlc3RzLiBUaGUgZmFjdCB0aGF0IEkNCm1vZGlmaWVkIHRoZSBTUlAgaW5pdGlhdG9y\n" - "IGJlZm9yZSB0aGlzIGhhbmcgb2NjdXJyZWQgZG9lcyBub3QgbWVhbiB0aGF0IHRoZQ0KYXBwcm9h\n" - "Y2ggb2YgeW91ciBwYXRjaCBpcyBmaW5lLiBXaGF0IHRoaXMgbWVhbnMgaXMgdGhhdCBhbGwgeW91\n" - "ciBwYXRjaCBkb2VzDQppcyB0byByZWR1Y2UgdGhlIHJhY2Ugd2luZG93IGFuZCB0aGF0IHRoZXJl\n" - IGlzIHN0aWxsIGEgcmFjZSB3aW5kb3cuDQoNCkJhcnQu + "On Tue, 2017-11-07 at 18:15 +0800, Ming Lei wrote:\n" + "> Last time, you didn't mention the target patch for setting its\n" + "> can_queue as 1, so I think you can't reproduce the issue on upstream\n" + "> kernel without out-of-tree patch. Then looks it is another issue,\n" + "> and we are making progress actually.\n" + "\n" + "If I don't trust a patch I introduce additional tests. The fact that I\n" + "modified the SRP initiator before this hang occurred does not mean that the\n" + "approach of your patch is fine. What this means is that all your patch does\n" + "is to reduce the race window and that there is still a race window.\n" + "\n" + Bart. -cdb35b9a5f3a849bc28755388cc234df4cd827aec4ad0a98aaf32e5ac8fb0312 +51f8defe9b1b72a7ea312a9af6b022bc4476a7de29dc3da8eef6d3da3d9c42d3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.