All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH] drm/i915: Include intel_engine_is_idle() status in engine pretty-printer
Date: Wed, 08 Nov 2017 14:26:12 +0200	[thread overview]
Message-ID: <1510143972.4626.16.camel@linux.intel.com> (raw)
In-Reply-To: <20171107152211.19930-1-chris@chris-wilson.co.uk>

On Tue, 2017-11-07 at 15:22 +0000, Chris Wilson wrote:
> Upon parking, if we discover an active engine we dump its state. Follow
> that state with an indication of whether the engine was idle.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=103479
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>

<SNIP>

> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1835,6 +1835,7 @@ void intel_engine_dump(struct intel_engine_cs *engine, struct drm_printer *m)
>  	}
>  	spin_unlock_irq(&b->rb_lock);
>  
> +	drm_printf(m, "Idle? %s\n", yesno(intel_engine_is_idle(engine)));

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2017-11-08 12:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 15:22 [PATCH] drm/i915: Include intel_engine_is_idle() status in engine pretty-printer Chris Wilson
2017-11-07 16:03 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-11-08 12:25 ` ✓ Fi.CI.BAT: success " Patchwork
2017-11-08 12:26 ` Joonas Lahtinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510143972.4626.16.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kuoppala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.