From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.purdie@linuxfoundation.org>
Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161])
	by mail.openembedded.org (Postfix) with ESMTP id CC0B67822A
	for <bitbake-devel@lists.openembedded.org>;
	Wed,  8 Nov 2017 18:09:20 +0000 (UTC)
Received: from hex ([192.168.3.34]) (authenticated bits=0)
	by dan.rpsys.net (8.15.2/8.15.2/Debian-3) with ESMTPSA id
	vA8I9GBZ031668
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128
	verify=NOT); Wed, 8 Nov 2017 18:09:17 GMT
Message-ID: <1510164556.3952.17.camel@linuxfoundation.org>
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
	bitbake-devel@lists.openembedded.org
Date: Wed, 08 Nov 2017 18:09:16 +0000
In-Reply-To: <03c9c452-1fab-60e3-2247-e6235482e718@gmail.com>
References: <1508844944-5761-1-git-send-email-andr2000@gmail.com>
	<1508844944-5761-4-git-send-email-andr2000@gmail.com>
	<1510062330.3952.8.camel@linuxfoundation.org>
	<03c9c452-1fab-60e3-2247-e6235482e718@gmail.com>
X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 
Mime-Version: 1.0
X-Virus-Scanned: clamav-milter 0.99.2 at dan
X-Virus-Status: Clean
Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH 3/4] fetch2/repo: Make fetcher always sync on unpack
X-BeenThere: bitbake-devel@lists.openembedded.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Patches and discussion that advance bitbake development
	<bitbake-devel.lists.openembedded.org>
List-Unsubscribe: <http://lists.openembedded.org/mailman/options/bitbake-devel>, 
	<mailto:bitbake-devel-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.openembedded.org/pipermail/bitbake-devel/>
List-Post: <mailto:bitbake-devel@lists.openembedded.org>
List-Help: <mailto:bitbake-devel-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.openembedded.org/mailman/listinfo/bitbake-devel>, 
	<mailto:bitbake-devel-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Nov 2017 18:09:21 -0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Tue, 2017-11-07 at 21:31 +0200, Oleksandr Andrushchenko wrote:
> On 11/07/2017 03:45 PM, Richard Purdie wrote:
> > 
> > On Tue, 2017-10-24 at 14:35 +0300, Oleksandr Andrushchenko wrote:
> > > 
> > > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > > 
> > > Currently if repo has fetched the repository and
> > > cached it to a tar file it never runs repo sync again,
> > > thus making the build use potentially outdated repo.
> > > Fix this by implementing unpack functionality which runs
> > > repo sync.
> > This sounds incorrect to me. The unpack task is not meant to touch
> > the
> > network at all, all network access should be done in the fetch
> > function.
> agree, so, instead this should be done via supporting source
> 
> revisions, so fetcher can deal with it? Is this understanding
> correct?

Yes, correct.

Cheers,

Richard