All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kahola <mika.kahola@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Return early when pipes are not available
Date: Thu, 09 Nov 2017 13:11:05 +0200	[thread overview]
Message-ID: <1510225865.16370.3.camel@intel.com> (raw)
In-Reply-To: <151022530410.826.8339091200992722295@mail.alporthouse.com>

On Thu, 2017-11-09 at 11:01 +0000, Chris Wilson wrote:
> Quoting Mika Kahola (2017-11-09 10:49:52)
> > 
> > At least in Coffee Lake it happens that we start initiliazing audio
> > when
> > no display is connected. This was discovered by CI when running IGT
> > test
> > case
> > 
> > drv_module_reload --r basic-no-display
> > 
> > The issue here is that the 'intel_device_info_runtime_init()' sets
> > num_pipes to 0 but before this happens the audio part has already
> > started
> > to initialize itself. Later on the num_pipes is updated to 0 in
> > intel_device_info_runtime_init() and we hit that when audio part is
> > digging
> > out ELD. This causes a warning in dmesg. To fix this issue, let's
> > check the
> > number of available pipes when trying to read out ELD.
> dev_info_runtime_init() is too late. It depends on mmio being enabled
> to
> probe the HW and nothing else; so move it to i915_driver_init_mmio()?
Ok. I could try that. I was also thinking that is there a way to
postpone audio initialization?

> -Chris
-- 
Mika Kahola - Intel OTC

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-11-09 11:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09 10:49 [PATCH] drm/i915: Return early when pipes are not available Mika Kahola
2017-11-09 11:01 ` Chris Wilson
2017-11-09 11:11   ` Mika Kahola [this message]
2017-11-09 13:15     ` Ville Syrjälä
2017-11-10 12:22       ` Mika Kahola
2017-11-10 13:22         ` Jani Nikula
2017-11-10 13:34           ` Mika Kahola
2017-11-10 13:37             ` Saarinen, Jani
2017-11-09 11:27 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-09 12:54 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510225865.16370.3.camel@intel.com \
    --to=mika.kahola@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.